Skip to content

fix(knowledge): pluralize the module header and root breadcrumb - #6516

Merged
j15z merged 1 commit into
stagingfrom
fix/plural-knowledge-bases-in-sidebar
Aug 11, 2026
Merged

fix(knowledge): pluralize the module header and root breadcrumb#6516
j15z merged 1 commit into
stagingfrom
fix/plural-knowledge-bases-in-sidebar

Conversation

@j15z

@j15z j15z commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Follow-up to fix(sidebar): pluralize the Knowledge bases nav label #6514: rename the Knowledge Base module's page header, browser-tab title, and loading skeleton from "Knowledge Base" to "Knowledge bases" so they match the sidebar nav label
  • Apply the same rename to the root breadcrumb in the KB detail and document views (and their loading skeletons), and to the "Move to" root option
  • Singular entity copy is untouched ("Create/Edit/Delete Knowledge Base", KB-name fallbacks, "Knowledge base not found")

Type of Change

  • Bug fix

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Aug 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Aug 11, 2026 1:11am

Request Review

@cursor

cursor Bot commented Aug 11, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Copy-only label changes in knowledge workspace routes; no logic, API, or data handling changes.

Overview
Renames module-level Knowledge UI copy from Knowledge Base to Knowledge bases so it matches the sidebar nav label (follow-up to #6514).

The list page metadata title, Resource.Header title, and loading skeleton title use the plural form. KB detail and document views update the root breadcrumb (and editor/loading breadcrumb variants) the same way. Singular strings for individual entities—modals, delete flows, name fallbacks like knowledgeBaseName, and document metadata parents—stay unchanged.

Reviewed by Cursor Bugbot for commit 4e12dcc. Bugbot is set up for automated code reviews on this repo. Configure here.

@greptile-apps

greptile-apps Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR consistently renames the Knowledge Base module-level copy to “Knowledge bases” while preserving singular copy for individual entities.

  • Updates page metadata, module headers, and loading fallbacks.
  • Updates root breadcrumbs across detail, document, error, editor, and loading states.
  • Updates the folder root and “Move to” root option through the shared module label constant.

Confidence Score: 5/5

The PR appears safe to merge because the changes are limited to consistent module-level copy updates and preserve singular entity wording.

The changed strings only affect displayed collection labels and metadata; navigation, data flow, entity fallbacks, and runtime contracts remain unchanged.

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/knowledge/[id]/[documentId]/document.tsx Updates every document-view root breadcrumb state to the plural module label without changing entity labels or navigation behavior.
apps/sim/app/workspace/[workspaceId]/knowledge/[id]/[documentId]/loading.tsx Aligns the document loading breadcrumb with the rendered document view.
apps/sim/app/workspace/[workspaceId]/knowledge/[id]/base.tsx Pluralizes the detail view’s module header and root breadcrumb while retaining singular knowledge-base name fallbacks.
apps/sim/app/workspace/[workspaceId]/knowledge/[id]/loading.tsx Aligns the detail loading breadcrumb with the completed detail view.
apps/sim/app/workspace/[workspaceId]/knowledge/knowledge.tsx Changes the shared collection label used by the list header, root breadcrumb, and move destination.
apps/sim/app/workspace/[workspaceId]/knowledge/loading.tsx Updates the collection loading header to match the final module header.
apps/sim/app/workspace/[workspaceId]/knowledge/page.tsx Updates the collection page’s browser metadata title to the plural module name.

Reviews (1): Last reviewed commit: "fix(knowledge): pluralize the module hea..." | Re-trigger Greptile

@j15z
j15z merged commit 4d37572 into staging Aug 11, 2026
30 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/plural-knowledge-bases-in-sidebar branch August 11, 2026 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant