fix(ci): include auth package in app Docker prune - #6538
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryLow Risk Overview The sim app already imports Reviewed by Cursor Bugbot for commit 9d7861c. Bugbot is set up for automated code reviews on this repo. Configure here. |
Greptile SummaryDeclares
Confidence Score: 5/5The PR appears safe to merge, with the manifest and lockfile consistently correcting the pruned dependency graph. The declared package exists, exports the subpaths imported by the app, follows the repository’s existing workspace dependency convention, and is represented consistently in the lockfile.
|
| Filename | Overview |
|---|---|
| apps/sim/package.json | Adds the missing direct @sim/auth workspace dependency used by the application. |
| bun.lock | Mirrors the manifest update in the app workspace’s locked dependency list. |
Reviews (1): Last reviewed commit: "fix(ci): include auth package in app pru..." | Re-trigger Greptile
Summary
Declare
@sim/authas a direct workspace dependency ofapps/simand update the lockfile.Root cause
The v2 application code imports
@sim/auth/principal, butapps/sim/package.jsondid not declare@sim/auth. Full-monorepo CI installs every workspace and therefore resolved the undeclared package, whiledocker/app.Dockerfilerunsturbo prune sim --docker. Turbo correctly omittedpackages/authfrom that pruned build graph, causing the staging image build to fail withModule not found: Can't resolve '@sim/auth/principal'.Impact
The app Docker image can include and resolve
@sim/auth/principalduring the staging build.Verification
turbo prune sim --dockerfrom this branch.Added @sim/auth.apps/sim/package.jsonandbun.lockdependency entries.