Skip to content

fix(cmdk): update search-modal assertions to the renamed New chat label - #6549

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/search-modal-new-chat-assertions
Aug 11, 2026
Merged

fix(cmdk): update search-modal assertions to the renamed New chat label#6549
waleedlatif1 merged 1 commit into
stagingfrom
fix/search-modal-new-chat-assertions

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Fix/lowercase wording #6543 renamed the cmdk ask-Sim label to sentence case (New chat: ${query}, search-modal.tsx:1094) but left search-modal.test.tsx:152 and :195 asserting New Chat
  • Those two assertions have been failing Test and Build / Lint and Test on staging for every PR since, unrelated to whatever that PR changed
  • Test was stale, source is correct — updated the assertions to match

Type of Change

  • Bug fix

Testing

search-modal.test.tsx 19/19 pass. Confirmed the same 2 failures reproduce on clean origin/staging without this change.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

#6543 renamed the ask-Sim label to sentence case but left the two assertions
expecting 'New Chat', which has been failing Lint and Test on staging for
every PR since.
@vercel

vercel Bot commented Aug 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Aug 11, 2026 6:20pm

Request Review

@cursor

cursor Bot commented Aug 11, 2026

Copy link
Copy Markdown

PR Summary

Cursor Bugbot is generating a summary for commit 1ca5c7c. Configure here.

@waleedlatif1
waleedlatif1 merged commit 2f1bb5a into staging Aug 11, 2026
22 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/search-modal-new-chat-assertions branch August 11, 2026 18:21
@greptile-apps

greptile-apps Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR corrects two stale SearchModal test assertions to match the existing sentence-case “New chat” label.

  • Updates the ask-mode label assertion for a Slack launch query.
  • Updates the corresponding assertion after keyboard mode switching.

Confidence Score: 5/5

The PR appears safe to merge because both test-only changes accurately reflect the existing production label.

The updated expectations match the hardcoded New chat: ${searchQuery} value rendered in ask mode, and no blocking or non-blocking defects remain.

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/search-modal/search-modal.test.tsx Both assertions now match the production SearchModal label, with no actionable issues found.

Reviews (1): Last reviewed commit: "fix(cmdk): update search-modal assertion..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant