-
Notifications
You must be signed in to change notification settings - Fork 3.8k
fix(desktop): fix background tab spawning #6590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| import { describeRunningCommand } from '@sim/terminal-protocol' | ||
| import { describe, expect, it } from 'vitest' | ||
|
|
||
| describe('describeRunningCommand', () => { | ||
| it('names the program of a bare command', () => { | ||
| expect(describeRunningCommand('bun run dev')).toBe('bun') | ||
| }) | ||
|
|
||
| it('takes the basename of an absolute program path', () => { | ||
| expect(describeRunningCommand('/opt/homebrew/bin/claude --resume')).toBe('claude') | ||
| }) | ||
|
|
||
| it('drops the cd/export preamble an agent-launched terminal carries', () => { | ||
| const command = | ||
| 'cd /Users/someone/Desktop/sim && export PATH="/opt/homebrew/bin:$PATH" && claude "Fix this runtime error in this repo: file upload fails"' | ||
| expect(describeRunningCommand(command)).toBe('claude') | ||
| }) | ||
|
|
||
| it('ignores separators inside quotes', () => { | ||
| expect(describeRunningCommand('claude "build && test; deploy | ship"')).toBe('claude') | ||
| expect(describeRunningCommand("claude 'a && b'")).toBe('claude') | ||
| }) | ||
|
|
||
| it('honors backslash escapes only where the shell does', () => { | ||
| // Escaped quote keeps the double-quoted run open, so `&&` stays quoted. | ||
| expect(describeRunningCommand('claude "say \\" && rm -rf /"')).toBe('claude') | ||
| // A backslash is literal inside single quotes, so that run closes and the | ||
| // following `&&` is a real separator. | ||
| expect(describeRunningCommand("claude 'a\\' && jest")).toBe('jest') | ||
| }) | ||
|
|
||
| it('skips environment assignments and wrapper words', () => { | ||
| expect(describeRunningCommand('NODE_ENV=test bun test')).toBe('bun') | ||
| expect(describeRunningCommand('sudo /usr/bin/docker compose up')).toBe('docker') | ||
| expect(describeRunningCommand('env FOO=1 nohup python train.py')).toBe('python') | ||
| }) | ||
|
|
||
| it('reads the last stage of a pipeline', () => { | ||
| expect(describeRunningCommand('cat log.txt | grep error | less')).toBe('less') | ||
| }) | ||
|
|
||
| it('bounds a label it cannot reduce to a program name', () => { | ||
| const label = describeRunningCommand(`--${'x'.repeat(200)}`) | ||
| expect(label.length).toBeLessThanOrEqual(33) | ||
| expect(label.endsWith('…')).toBe(true) | ||
| }) | ||
|
|
||
| it('describes an unannounced command rather than returning nothing', () => { | ||
| expect(describeRunningCommand(' ')).toBe('a command') | ||
| }) | ||
| }) |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.