Skip to content

improvement(settings): drop the Privacy row's description - #6844

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/privacy-row-description
Aug 19, 2026
Merged

improvement(settings): drop the Privacy row's description#6844
waleedlatif1 merged 1 commit into
stagingfrom
fix/privacy-row-description

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

Removes the description under the Privacy settings row in General settings.

The row already reads "Privacy settings" with a Manage chip, and the sub-view it opens carries its own title and description ("Privacy — Control what Sim collects about how you use it."). The sentence beneath the row restated that a step before the user had asked for it.

Also drops the flex flex-col gap-3 wrapper the paragraph shared with the row — with the paragraph gone, the row is the section's only child and the wrapper does nothing.

Note the Account section below keeps its description on purpose: "Delete account" is destructive and irreversible, so the consequence belongs on the row rather than one click away.

Type of Change

  • Other: copy/layout cleanup

Testing

type-check, lint:check, all 29 check:audits, and 199 tests pass. No behavior change — isHosted is still imported and used by the Home page action above.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

The row reads Privacy settings with a Manage chip, and the sub-view it opens
titles and describes itself — the sentence beneath it restated that before the
user had asked for it. The wrapper it shared with the row goes too, now that
the row is the section's only child.
@vercel

vercel Bot commented Aug 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Aug 19, 2026 4:47am

Request Review

@cursor

cursor Bot commented Aug 19, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Copy and layout-only change in settings UI with no logic or data handling changes.

Overview
Removes the explanatory paragraph under Privacy settings in General settings and drops the extra column wrapper that only existed to group that text with the row.

The row still shows Privacy settings with a Manage chip that opens PrivacyView, which already has its own title and description. Delete account in Account keeps its on-row warning text.

Reviewed by Cursor Bugbot for commit a33f385. Configure here.

@greptile-apps

greptile-apps Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Removes the redundant description beneath the Privacy settings row and simplifies its markup while preserving the existing Manage action.

  • Removes hosted and self-hosted privacy description copy.
  • Removes the now-unnecessary column wrapper.
  • Retains the Privacy label and navigation behavior unchanged.

Confidence Score: 5/5

The PR appears safe to merge with no actionable issues identified.

The simplified markup matches sibling settings rows, preserves the Manage action, and does not violate the surrounding section’s layout contract.

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/settings/components/general/general.tsx Simplifies the Privacy section to match other single-row settings sections without changing behavior.

Reviews (1): Last reviewed commit: "improvement(settings): drop the Privacy ..." | Re-trigger Greptile

@waleedlatif1
waleedlatif1 merged commit ae8b169 into staging Aug 19, 2026
30 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/privacy-row-description branch August 19, 2026 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant