Skip to content

fix(ui): keep modal popovers interactive - #7435

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/fix-modal-combobox-interaction
Sep 3, 2026
Merged

fix(ui): keep modal popovers interactive#7435
waleedlatif1 merged 1 commit into
stagingfrom
codex/fix-modal-combobox-interaction

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • keep portaled popovers interactive when they open inside modal content
  • add regression coverage for modal option selection and preserve non-modal behavior

Type of Change

  • Bug fix

Testing

  • bun --filter @sim/emcn test
  • bun --filter @sim/emcn type-check
  • bun run lint:check
  • bun run check:audits
  • bun run apps/sim/scripts/check-block-registry.ts origin/staging

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 3, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 3, 2026 4:11pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR makes portaled Popovers modal while rendered within modal content so their options remain interactive, while preserving default behavior outside modals.

  • Propagates InsideModalContext into the Radix Popover modal setting.
  • Adds regression coverage for option selection and body pointer-event behavior.

Confidence Score: 5/5

The PR appears safe to merge with no concrete blocking or non-blocking defects identified.

The modal-aware Popover behavior follows an existing sibling-component pattern, and the regression test verifies the intended pointer-event and selection behavior without changing non-modal behavior.

Important Files Changed

Filename Overview
packages/emcn/src/components/popover/popover.tsx Uses the established modal-context pattern to keep portaled Popover content interactive within an enclosing modal.
packages/emcn/src/components/combobox/combobox.dom.test.tsx Adds focused DOM regression coverage for modal option selection and unchanged non-modal pointer-event behavior.

Reviews (1): Last reviewed commit: "fix(ui): keep modal popovers interactive" | Re-trigger Greptile

@waleedlatif1
waleedlatif1 merged commit 44d5fec into staging Sep 3, 2026
29 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/fix-modal-combobox-interaction branch September 3, 2026 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant