fix(ui): keep modal popovers interactive - #7435
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Greptile SummaryThis PR makes portaled Popovers modal while rendered within modal content so their options remain interactive, while preserving default behavior outside modals.
Confidence Score: 5/5The PR appears safe to merge with no concrete blocking or non-blocking defects identified. The modal-aware Popover behavior follows an existing sibling-component pattern, and the regression test verifies the intended pointer-event and selection behavior without changing non-modal behavior.
|
| Filename | Overview |
|---|---|
| packages/emcn/src/components/popover/popover.tsx | Uses the established modal-context pattern to keep portaled Popover content interactive within an enclosing modal. |
| packages/emcn/src/components/combobox/combobox.dom.test.tsx | Adds focused DOM regression coverage for modal option selection and unchanged non-modal pointer-event behavior. |
Reviews (1): Last reviewed commit: "fix(ui): keep modal popovers interactive" | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
Checklist