Skip to content

fix(monday): forward users through app installation - #7436

Merged
waleedlatif1 merged 2 commits into
stagingfrom
fix/monday-oauth-auto-install
Sep 3, 2026
Merged

fix(monday): forward users through app installation#7436
waleedlatif1 merged 2 commits into
stagingfrom
fix/monday-oauth-auto-install

Conversation

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor

Summary

  • Add the documented Monday OAuth authorization parameter force_install_if_needed=true.
  • When the Sim app is not installed in a Monday account, Monday can now route an account admin through installation and then resume OAuth instead of stopping at the blocking App is not installed screen.
  • Keep the parameter in the shared Monday connector configuration so ordinary and managed OAuth flows both inherit it.
  • Verify the parameter on the real generated Monday authorization URL.

This does not bypass Monday account policy: a non-admin still needs an account admin to install the app, and the Monday app/version must be available to that account.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Testing

  • Focused OAuth tests: 69 passed
  • Full apps/sim Vitest suite: 40,552 passed, 67 skipped
  • bun run --cwd apps/sim type-check
  • bun run --cwd apps/sim lint:check
  • bun run check:api-validation
  • bun run check

Checklist

  • Code follows the existing connector configuration pattern
  • Tests cover the generated authorization URL
  • No database, environment, callback, or API-key behavior changes

@vercel

vercel Bot commented Sep 3, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 3, 2026 4:46pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR adds Monday’s installation-forwarding authorization parameter to the shared connector configuration and verifies it through the production OAuth plugin route.

  • Adds force_install_if_needed=true to the Monday connector.
  • Replaces direct URL construction in the test with Better Auth’s real link-account flow.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains; the previously reported test-wiring issue is fixed because the test now uses the production connector builder and OAuth plugin path.

Important Files Changed

Filename Overview
apps/sim/lib/auth/connectors/providers.ts Adds the documented Monday authorization parameter to the shared connector consumed by production OAuth flows.
apps/sim/lib/oauth/oauth.test.ts Uses the production connector builder and Better Auth plugin route to assert that the generated authorization URL includes the installation parameter.

Reviews (2): Last reviewed commit: "test(monday): exercise OAuth link route" | Re-trigger Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

Comment thread apps/sim/lib/oauth/oauth.test.ts Outdated
@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@waleedlatif1
waleedlatif1 merged commit 8c2e81c into staging Sep 3, 2026
28 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/monday-oauth-auto-install branch September 3, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants