Skip to content

improvement(markdown): upgrade marked to v18 - #7508

Merged
waleedlatif1 merged 2 commits into
stagingfrom
codex/upgrade-marked-18
Sep 5, 2026
Merged

improvement(markdown): upgrade marked to v18#7508
waleedlatif1 merged 2 commits into
stagingfrom
codex/upgrade-marked-18

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Sep 5, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • upgrade Marked to v18 across direct and transitive consumers
  • improve Markdown parser performance on pathological inputs

Type of Change

  • Improvement

Testing

  • 138 focused Markdown, email, and renderer tests pass
  • monorepo type-check, lint, frozen lockfile validation, and repository audits pass

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Existing tests pass
  • No new warnings introduced
  • CLA requirements are satisfied

@waleedlatif1
waleedlatif1 requested a review from a team as a code owner September 5, 2026 01:47
@vercel

vercel Bot commented Sep 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 5, 2026 1:58am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR upgrades the Sim application’s direct Marked dependency to 18.0.11 and adds a root override that consolidates direct and transitive Marked consumers onto that version.

  • Updates apps/sim from Marked 15.0.12 to 18.0.11.
  • Adds a root-level Marked override.
  • Regenerates the Bun lockfile to use the consolidated resolution.

Confidence Score: 5/5

The PR appears safe to merge with no actionable new issue established in the current changes.

The dependency and lockfile changes consistently resolve Marked to 18.0.11, and no concrete compatibility, security, or repository-rule failure was established. The previous transitive-version finding was addressed by the override and its thread was resolved after the author reported passing focused tests, type-checking, and frozen-lockfile validation.

Important Files Changed

Filename Overview
package.json Adds a root override pinning all Marked consumers to version 18.0.11.
apps/sim/package.json Upgrades the Sim application’s direct Marked dependency from 15.0.12 to 18.0.11.
bun.lock Regenerates dependency resolution so previously nested Marked versions resolve to 18.0.11.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  Root[Root marked override: 18.0.11] --> Sim[apps/sim direct dependency]
  Root --> Email[React Email consumers]
  Root --> Editor[TipTap and Monaco consumers]
  Root --> Renderers[Mermaid and Streamdown consumers]
  Sim --> Lock[Single bun.lock resolution]
  Email --> Lock
  Editor --> Lock
  Renderers --> Lock
Loading

Reviews (2): Last reviewed commit: "fix(markdown): enforce marked v18 across..." | Re-trigger Greptile

Comment thread bun.lock Outdated
@waleedlatif1
waleedlatif1 force-pushed the codex/upgrade-marked-18 branch from 3ab5667 to 5bdbb00 Compare September 5, 2026 01:55
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@waleedlatif1
waleedlatif1 merged commit df2d893 into staging Sep 5, 2026
38 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/upgrade-marked-18 branch September 5, 2026 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant