Skip to content

fix(cli): keep only the agent name from a versioned AI_AGENT declaration - #7775

Merged
waleedlatif1 merged 3 commits into
stagingfrom
fix/cli-agent-name
Sep 11, 2026
Merged

fix(cli): keep only the agent name from a versioned AI_AGENT declaration#7775
waleedlatif1 merged 3 commits into
stagingfrom
fix/cli-agent-name

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Claude Code advertises itself as AI_AGENT=claude-code_2-1-268_agent (name, dashed version, role). The first real event showed that value verbatim, which would split the coding-agent breakdown into one slice per release; only the name before the first underscore is kept now
  • Usage-data docs note that the analytics service derives an approximate location from the report's address

Type of Change

  • Bug fix

Testing

  • Unit tests for the versioned declaration and a separator-only declaration
  • Verified end to end: a command run from a locally built CLI arrived in PostHog with the expected properties

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 11, 2026 6:18pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge with no accepted new findings.

Summary

  • Recognizes versioned declarations such as claude-code_2-1-268_agent.
  • Preserves non-versioned underscored declarations such as github_copilot_vscode_agent.
  • Documents that the analytics service derives approximate location from the report’s network address.

Reviews (2) · Last reviewed commit: "fix(cli): trim only the versioned AI_AGE..."

Comment thread packages/sim-cli/src/telemetry/coding-agent.ts Outdated
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@waleedlatif1
waleedlatif1 merged commit 334a3fd into staging Sep 11, 2026
33 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/cli-agent-name branch September 11, 2026 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant