Skip to content

feat(assistant): support image attachments - #7776

Merged
waleedlatif1 merged 2 commits into
stagingfrom
codex/organization-assistant-images
Sep 11, 2026
Merged

feat(assistant): support image attachments#7776
waleedlatif1 merged 2 commits into
stagingfrom
codex/organization-assistant-images

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Add image paste, drag-and-drop, and a plus-button picker to organization Assistant chats, including previews and image-only messages.
  • Reuse upload sessions with private uploader/organization access, image validation, bounded model input, and account/organization deletion cleanup.
  • Preserve image attachments through queued-message editing and send recovery.

Type of Change

  • Feature

Testing

  • 391 feature tests passed across 20 focused upload, authorization, chat, composer, and recovery suites; 87 upload/account-deletion tests passed for the cleanup fix.
  • App/auth type checks, lint, all 46 repository audits, API boundary validation, and docs checks passed.
  • Verified picker, clipboard paste, removal, and image-only submission in a local component preview with mocked uploads; checked desktop and 390px layouts.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 11, 2026 6:35pm UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@greptile-apps

greptile-apps Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with the previous account-deletion finding addressed and no new blocking issues identified.

Summary

  • Reuses upload sessions with uploader and organization authorization, validated image decoding, and bounded model input.
  • Preserves attachments through queued-message editing and send recovery.
  • The latest changes add post-commit account-deletion cleanup and retryable orphan sweeping while retaining active accounts’ images.
  • No new actionable issues were identified in the changes since the previous review.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  Composer["Paste, drop, or pick images"] --> Upload["Authorized organization upload session"]
  Upload --> Validate["Validate and decode image"]
  Validate --> Owned["Completed private-image ownership record"]
  Owned --> Preview["Authorized preview"]
  Owned --> Prepare["Authorized, bounded model preparation"]
  Prepare --> Chat["Assistant turn and persisted attachment metadata"]
  Owned --> Account["Account deletion commits"]
  Account --> Purge["Delete image objects"]
  Purge --> Success["Remove expired ownership records after successful deletion"]
  Purge --> Retry["Retain recent uploads and failed deletions"]
  Retry --> Sweep["Orphan sweep retries cleanup"]
Loading

Reviews (2) · Last reviewed commit: "fix(assistant): clean up orphaned image ..."

Comment thread apps/sim/lib/uploads/upload-session/service.ts Outdated
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@waleedlatif1
waleedlatif1 merged commit d0c825b into staging Sep 11, 2026
25 of 26 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/organization-assistant-images branch September 11, 2026 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant