Skip to content

Repair Week 1 Day 2 RoPE learner contract - #286

Merged
skyzh merged 2 commits into
mainfrom
sentinel/tiny-week1-day2-rope-contract
Sep 3, 2026
Merged

Repair Week 1 Day 2 RoPE learner contract#286
skyzh merged 2 commits into
mainfrom
sentinel/tiny-week1-day2-rope-contract

Conversation

@skyzh

@skyzh skyzh commented Sep 3, 2026

Copy link
Copy Markdown
Owner

Summary

  • Rewrite Week 1 Day 2 around the intentionally empty RoPE starter and the exact frequency-table construction learners own.
  • Turn the two pair layouts into capability-led checkpoints with honest first-run feedback, dtype preservation, and the Day 3 query/key handoff.
  • Add public dtype preservation and contrasting N=2, D=8, base=10 witnesses across both layouts while retaining independent mx.fast.rope value oracles.

Verification

  • pdm run test --week 1 --day 2 -- -k task_1 -q — expected red on the empty starter.
  • pdm run test --week 1 --day 2 -- -q --tb=no — expected red on the empty starter.
  • pdm run test-refsol --week 1 --day 2 -- -k task_1 -q — 16 passed, 16 deselected.
  • pdm run test-refsol --week 1 --day 2 -- -q — 32 passed.
  • mdbook build book — passed.
  • ruff format --check tests_refsol/test_week_1_day_2.py — passed.
  • Exact two-path, link/command/equation, test-byte, complement-record, and symlink preservation checks — passed.

Scope

Only book/src/week1-02-positional-encodings.md and tests_refsol/test_week_1_day_2.py change. Starter/reference implementation, tooling, navigation, adjacent and later lessons, Week 4, and publication surfaces remain unchanged.

AI-Assisted: GPT-5.6 Sol + Sentinel

@skyzh
skyzh marked this pull request as ready for review September 3, 2026 05:14
@skyzh
skyzh merged commit cea6eb2 into main Sep 3, 2026
1 check passed
@skyzh
skyzh deleted the sentinel/tiny-week1-day2-rope-contract branch September 3, 2026 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant