Skip to content

Updates for v2 based on feedback#439

Merged
stevengill merged 3 commits intoslackapi:@slack/bolt@nextfrom
stevengill:updates
Mar 25, 2020
Merged

Updates for v2 based on feedback#439
stevengill merged 3 commits intoslackapi:@slack/bolt@nextfrom
stevengill:updates

Conversation

@stevengill
Copy link
Copy Markdown
Member

Summary

Updates based on comments on #380 & #381

Requirements (place an x in each [ ])

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 24, 2020

Codecov Report

Merging #439 into @slack/bolt@next will increase coverage by 0.61%.
The diff coverage is 29.41%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##           @slack/bolt@next     #439      +/-   ##
====================================================
+ Coverage              85.1%   85.71%   +0.61%     
====================================================
  Files                     7        7              
  Lines                   537      532       -5     
  Branches                158      156       -2     
====================================================
- Hits                    457      456       -1     
+ Misses                   52       48       -4     
  Partials                 28       28
Impacted Files Coverage Δ
src/errors.ts 100% <100%> (+6.06%) ⬆️
src/ExpressReceiver.ts 72.44% <20%> (+1.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8abaf9...cf56506. Read the comment docs.

@seratch
Copy link
Copy Markdown
Contributor

seratch commented Mar 25, 2020

@stevengill can you cherry-pick this commit for corresponding changes to Japanese docs? https://github.com/seratch/bolt/commit/37bfd07ee9ecbae8d8d528ad7fb08968332342c5

Comment thread src/App.spec.ts Outdated
@stevengill stevengill merged commit 17d23d1 into slackapi:@slack/bolt@next Mar 25, 2020
@stevengill stevengill deleted the updates branch March 25, 2020 21:53
@stevengill stevengill restored the updates branch March 25, 2020 21:53
@stevengill stevengill deleted the updates branch March 25, 2020 21:53
@aoberoi aoberoi mentioned this pull request Mar 27, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants