Make App.handleError() private (v2)#446
Merged
stevengill merged 1 commit intoslackapi:@slack/bolt@nextfrom Mar 27, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## @slack/bolt@next #446 +/- ##
=================================================
Coverage 85.71% 85.71%
=================================================
Files 7 7
Lines 532 532
Branches 156 156
=================================================
Hits 456 456
Misses 48 48
Partials 28 28
Continue to review full report at Codecov.
|
seratch
approved these changes
Mar 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
App.handleError()method used to be used by theExpressReceiverbefore #439. Receivers no longer need this method because they are strictly downstream of the event handling in an app. Therefore it makes sense to turn this into a private method.Depends on #440 (integration tests will fail without it)
Requirements (place an
xin each[ ])