Skip to content

Conversation

@WilliamBergamin
Copy link
Contributor

@WilliamBergamin WilliamBergamin commented Oct 28, 2022

Bolt Java & SDK are using a deprecated script for coverage in the Coverage in the CI pipeline, this PR tried to solve this using Github actions

Category

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

improved CI build and removed deprecated codcov script
@WilliamBergamin WilliamBergamin added the enhancement M-T: A feature request for new functionality label Oct 28, 2022
@WilliamBergamin WilliamBergamin self-assigned this Oct 28, 2022
@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Merging #1079 (0455f63) into main (2c71786) will decrease coverage by 0.30%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1079      +/-   ##
============================================
- Coverage     76.84%   76.53%   -0.31%     
+ Complexity     3765     3764       -1     
============================================
  Files           409      409              
  Lines         11402    11631     +229     
  Branches       1150     1150              
============================================
+ Hits           8762     8902     +140     
- Misses         1947     2036      +89     
  Partials        693      693              
Impacted Files Coverage Δ
...xtension/block/element/CheckboxesElementBuilder.kt 57.89% <0.00%> (-13.54%) ⬇️
...ension/block/element/RadioButtonsElementBuilder.kt 57.89% <0.00%> (-13.54%) ⬇️
.../model/kotlin_extension/block/VideoBlockBuilder.kt 57.89% <0.00%> (-11.34%) ⬇️
...ension/block/element/OverflowMenuElementBuilder.kt 69.23% <0.00%> (-10.77%) ⬇️
...otlin_extension/block/ShareShortcutBlockBuilder.kt 64.70% <0.00%> (-10.30%) ⬇️
...tension/block/element/UsersSelectElementBuilder.kt 70.00% <0.00%> (-10.00%) ⬇️
...sion/block/element/ChannelsSelectElementBuilder.kt 73.91% <0.00%> (-8.44%) ⬇️
...sion/block/element/ExternalSelectElementBuilder.kt 73.91% <0.00%> (-8.44%) ⬇️
...on/block/element/MultiUsersSelectElementBuilder.kt 73.91% <0.00%> (-8.44%) ⬇️
...ension/block/composition/dsl/PlainTextObjectDsl.kt 25.00% <0.00%> (-8.34%) ⬇️
... and 33 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@seratch seratch added this to the 1.27.0 milestone Oct 31, 2022
Copy link
Contributor

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@seratch seratch merged commit 3a0f5a4 into slackapi:main Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement M-T: A feature request for new functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants