Skip to content

Conversation

@seratch
Copy link
Contributor

@seratch seratch commented Apr 12, 2025

Summary

This pull request resolves typos and misspellings in this project.

Requirements

@seratch seratch requested a review from a team as a code owner April 12, 2025 09:29
@salesforce-cla salesforce-cla bot added the cla:missing The CLA was not signed label Apr 12, 2025
@salesforce-cla
Copy link

Thanks for the contribution! Unfortunately we can't verify the commit author(s): seratch <s***@s***.local>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce Inc. Contributor License Agreement and this Pull Request will be revalidated.

@salesforce-cla salesforce-cla bot added cla:signed and removed cla:missing The CLA was not signed labels Apr 12, 2025
Copy link
Contributor

@vegeris vegeris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching these typos! 🙏

@codecov
Copy link

codecov bot commented Apr 14, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 62.92%. Comparing base (6dbc21e) to head (dec6c5c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/update/cli_autoupdate.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #35   +/-   ##
=======================================
  Coverage   62.91%   62.92%           
=======================================
  Files         210      210           
  Lines       22147    22147           
=======================================
+ Hits        13933    13935    +2     
+ Misses       7128     7126    -2     
  Partials     1086     1086           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mwbrooks mwbrooks self-assigned this Apr 14, 2025
@mwbrooks mwbrooks added docs M-T: Documentation work only semver:patch Use on pull requests to describe the release version increment labels Apr 14, 2025
@mwbrooks mwbrooks added this to the Next Release milestone Apr 14, 2025
Copy link
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ Woo, @seratch you're our first "external" contributor! 🎉 🥳 🙇🏻 🙇🏻 🙇🏻 🙇🏻

Thanks so much for catching our spelling mistakes. I'm relieved to see that they were contained to tests and comments 😅

We're going to use your PR as a chance to improve our external contribution process. At the moment, our E2E Tests cannot run automatically for forks due to security concerns. So, we're making a few tweaks that may enable us to manually trigger the tests after a PR review and display the status back to the PRs GitHub Status Check. 🟠 🟢 🔴

We'll merge your PR as soon as we can! 🙇🏻

Copy link
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 LGTM! And also thanks so much for sharing these fixes with a neat tool!

Before the tests can run on this PR I was wondering if it'd be possible to include the changes of #38 on main into this branch?

@zimeg zimeg changed the title Fix misspellings (used typos-cli for detecting) docs: fix misspellings (used typos-cli for detecting) Apr 18, 2025
@zimeg
Copy link
Member

zimeg commented Apr 18, 2025

📝 Quick update to the PR title for sake of conventional commit and I'm checking out the tests once more.

🧪 I hesitated to rebase since it's not so clear how token permissions might change, but another rebase might be needed to avoid changes to workflow files since changes made to main in 6dbc21e. I believe this causes an error creating pre-releases from a fork.

🔍 For quick testings sake I'll update the branch with hope that the workflow diff is causing strangeness and not other permissions, and I'll report back.

@zimeg
Copy link
Member

zimeg commented Apr 18, 2025

📣 How exciting! It was a difference in .github/workflows causing the release error. We now have a tag for testing for now:

Edit: Wait. It is at least perhaps a difference in workflow file. Permissions might still cause strangeness to watch out for 👁️‍🗨️

@zimeg
Copy link
Member

zimeg commented Apr 18, 2025

@seratch Thank you lots once more for these changes and your patience as we explore testing! 👾 ✨

The changes continue to LGTM and will be great to include in this next release so let's merge this now 🚀

Follow up on using typos-cli in CI might be interesting to avoid regressions of these fixes for words with more letters in later changes but all is seeming great in these commits.

@zimeg zimeg merged commit 758884c into slackapi:main Apr 18, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla:signed docs M-T: Documentation work only semver:patch Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants