-
Notifications
You must be signed in to change notification settings - Fork 24
docs: fix misspellings (used typos-cli for detecting) #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the contribution! Unfortunately we can't verify the commit author(s): seratch <s***@s***.local>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce Inc. Contributor License Agreement and this Pull Request will be revalidated. |
vegeris
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching these typos! 🙏
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #35 +/- ##
=======================================
Coverage 62.91% 62.92%
=======================================
Files 210 210
Lines 22147 22147
=======================================
+ Hits 13933 13935 +2
+ Misses 7128 7126 -2
Partials 1086 1086 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mwbrooks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ Woo, @seratch you're our first "external" contributor! 🎉 🥳 🙇🏻 🙇🏻 🙇🏻 🙇🏻
Thanks so much for catching our spelling mistakes. I'm relieved to see that they were contained to tests and comments 😅
We're going to use your PR as a chance to improve our external contribution process. At the moment, our E2E Tests cannot run automatically for forks due to security concerns. So, we're making a few tweaks that may enable us to manually trigger the tests after a PR review and display the status back to the PRs GitHub Status Check. 🟠 🟢 🔴
We'll merge your PR as soon as we can! 🙇🏻
zimeg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 LGTM! And also thanks so much for sharing these fixes with a neat tool!
Before the tests can run on this PR I was wondering if it'd be possible to include the changes of #38 on main into this branch?
|
📝 Quick update to the PR title for sake of conventional commit and I'm checking out the tests once more. 🧪 I hesitated to rebase since it's not so clear how token permissions might change, but another rebase might be needed to avoid changes to workflow files since changes made to 🔍 For quick testings sake I'll update the branch with hope that the workflow |
|
📣 How exciting! It was a difference in Edit: Wait. It is at least perhaps a difference in workflow file. Permissions might still cause strangeness to watch out for 👁️🗨️ |
|
@seratch Thank you lots once more for these changes and your patience as we explore testing! 👾 ✨ The changes continue to LGTM and will be great to include in this next release so let's merge this now 🚀 Follow up on using |
Summary
This pull request resolves typos and misspellings in this project.
Requirements