Skip to content

Conversation

@zimeg
Copy link
Member

@zimeg zimeg commented Apr 17, 2025

Summary

This PR updates outputs of the upgrade command to note if the latest SDK versions were checked.

Preview

Outputs now change depending on the path used 👾

$ slack version
Using slack v3.0.4
$ slack upgrade
✔ You are using the latest Slack CLI version
$ slack create asdf
$ cd asdf
$ slack upgrade
✔ You are using the latest Slack CLI and SDK versions

Reviewers

A handbuilt make of these changes might be useful for testing the shown version:

$ go build -ldflags="-X 'github.com/slackapi/slack-cli/internal/pkg/version.Version=3.0.4'" -o bin/slack

And these commands can be useful in testing cases with a bolt JS project:

$ npm install @slack/cli-hooks@1.0.0
$ npm install @slack/cli-hooks@latest

Requirements

@zimeg zimeg added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:patch Use on pull requests to describe the release version increment labels Apr 17, 2025
@zimeg zimeg added this to the Next Release milestone Apr 17, 2025
@zimeg zimeg self-assigned this Apr 17, 2025
@zimeg zimeg requested a review from a team as a code owner April 17, 2025 21:07
@codecov
Copy link

codecov bot commented Apr 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 62.89%. Comparing base (758884c) to head (6bde33d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/upgrade/upgrade.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
- Coverage   62.93%   62.89%   -0.05%     
==========================================
  Files         210      210              
  Lines       22147    22152       +5     
==========================================
- Hits        13938    13932       -6     
- Misses       7126     7134       +8     
- Partials     1083     1086       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Works well and looks good to me! Thanks for tightening up the UX here @zimeg!

Running upgrade OUTSIDE a project directory:

image

Running upgrade INSIDE a project directory:

image

@mwbrooks mwbrooks changed the title fix: note if "upgrade" checks include the latest sdk versions fix: 'upgrade' output includes SDK when inside a project dir Apr 17, 2025
@zimeg
Copy link
Member Author

zimeg commented Apr 17, 2025

@mwbrooks Thanks so much for sharing these previews 📺 ✨

I'm eager to merge this now but am wanting to check one or two more things with tests before so. One strange thing happening on the latest commit I notice is two runs of E2E test status. AFAICT this is from other experiments unrelated.

Another unrelated test change relates to cleaning up the artifacts used in testing forked changes after a merge!

@zimeg
Copy link
Member Author

zimeg commented Apr 18, 2025

@mwbrooks Thanks yet again for a review and preview.

Tests are passing as we might hope for these changes. I will merge this now for the next release with hopes that this next upgrade will be more clear 🫡

@zimeg zimeg merged commit f3ba824 into slackapi:main Apr 18, 2025
6 checks passed
@zimeg zimeg deleted the fix-update-project-latest-output branch April 18, 2025 19:06
@zimeg zimeg added the changelog Use on updates to be included in the release notes label Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented changelog Use on updates to be included in the release notes semver:patch Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants