Skip to content

fix: 'upgrade' output includes SDK when inside a project dir #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zimeg merged 3 commits into from
Apr 18, 2025
Merged

fix: 'upgrade' output includes SDK when inside a project dir #46

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f58bfc8
fix: note if update checks include the latest sdk versions
zimeg Apr 17, 2025
96f638b
chore: merge w main
zimeg Apr 17, 2025
6bde33d
chore: merge w main
zimeg Apr 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions cmd/upgrade/upgrade.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,14 @@ func checkForUpdates(clients *shared.ClientFactory, cmd *cobra.Command) error {

// Update notification messages are printed by the root command's persistent post-run (cmd/root.go).
// So this command only needs to print a message when everything is up-to-date.
if !updateNotification.HasUpdate() {
cmd.Printf("%s You are using the latest Slack CLI and SDK\n", style.Styler().Green("✔").String())
if updateNotification.HasUpdate() {
return nil
}

if clients.SDKConfig.Hooks.CheckUpdate.IsAvailable() {
cmd.Printf("%s You are using the latest Slack CLI and SDK versions\n", style.Styler().Green("✔").String())
} else {
cmd.Printf("%s You are using the latest Slack CLI version\n", style.Styler().Green("✔").String())
}

return nil
Expand Down
Loading