chore: make the tool-selection eval tolerant of Gemini's search-first pick - #95
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request stops the nightly tool-selection eval from failing when the Gemini judge picks a search tool as its first step on an ambiguous prompt.
The evals are there to make sure skills are not selected over MCP tools, as long as these eval select an MCP tool then they achieve their goal
Preview
N/A — test-only change.
Testing
make test-evaland confirmtests/eval/test_tool_selection.py::TestToolSelection::test_tool_selection[ambiguous-reply-in-thread]passes.Notes
Requirements
make testand the tests pass.