Skip to content

fix onboarding runtime validation and first-start routing - #444

Draft
vansin wants to merge 3 commits into
mainfrom
agent/onboarding-fixes
Draft

fix onboarding runtime validation and first-start routing#444
vansin wants to merge 3 commits into
mainfrom
agent/onboarding-fixes

Conversation

@vansin

@vansin vansin commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

What changed

  • declare and enforce the Bun prerequisite before Hub startup
  • make the first agent-node launch use the existing npx @sleep2agi/agent-node@preview fallback
  • reject blank provider credentials only for SDK execution nodes that actually require them
  • preserve keyless host_supervisor daemon startup
  • reject unknown explicit and persisted runtimes instead of silently falling back
  • preserve the legacy agent-sdk + Codex profile as codex-sdk
  • route codex-app-server through agent-node, never the Claude launcher, while labeling it preview / production locked
  • apply strict runtime parsing to both __custom__ batch inputs

Why

A clean-container onboarding audit found four user-facing failure modes: a hidden Bun prerequisite, an advertised-but-missing first-start runtime path, nodes that appeared online without usable provider credentials, and unsupported runtimes silently launching a different executable. The first correction also overreached by blocking keyless supervisor daemons and missed legacy/batch/CAS branches; this round closes those regressions.

Independent validation

  • fresh detached checkout at 91e0b85
  • Node 22.22.2, Bun 1.3.14
  • targeted onboarding tests: 54 pass / 0 fail / 120 expect
  • full bun test src: 146 pass / 0 fail / 283 expect
  • npm run typecheck: pass
  • npm run build: pass
  • git diff --check: clean

Detailed evidence: docs/tests/report-onboarding-fixes.txt.

Scope and remaining release work

This is a Draft PR and a scoped onboarding corrective pass, not a release approval. Before stable promotion:

  • align the README/default administrator bootstrap path
  • replace or explicitly govern the moving @preview tag; it is not a version pin
  • keep RFC-030 Policy Gateway, §8 review, production, deployment, and latest-tag gates locked

No merge, deployment, npm publication, or tag change is authorized by this PR.

@vansin

vansin commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

分诊(2026-07-29,通信龙):建议保留并 rebase,优先级高。

本 PR 与今天的两个 P0 高度重叠,而且部分工作今天被独立重做了一遍

当前状态:CONFLICTING / DIRTY,需 rebase 到 origin/main。冲突大概率来自今天合入的 #484(README)与 #483 / #489cli.ts)。

这条是「陈旧 PR 腐烂」的活样本:它躺了两周没人合,期间我们从零重新发现并修复了它已经修过的问题。每多躺一天,冲突只会更多,而重复劳动已经发生过一次。

建议:确认 owner → rebase → 走正常复核。若判断已被今天的改动完全覆盖而无需保留,也请明确关闭并说明理由,不要继续挂着腐烂。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants