fix: tolerate startxref offset near xref keyword#810
Closed
vitormattos wants to merge 2 commits into
Closed
Conversation
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
This was referenced Apr 25, 2026
Author
|
Superseded by the consolidation chain in the fork: vitormattos#36\n\nThis includes PR810 parser fix and regression coverage, integrated on top of PR808 stack with fixture/test consolidation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tolerate
startxrefoffsets that land on whitespace immediately before thexrefkeyword, or one byte intoxref.Why
Some malformed PDFs do not point
startxrefexactly at the beginning ofxref, even though the cross-reference table is still recoverable.Without this tolerance, parsing can fail with
Invalid object reference for $obj.on files that should still be recoverable.Validation
Validated against representative regressions from the corpora used in the larger PDF.js integration work:
outlines_for_editor.pdfveraPDF test suite 6-6-2-3-2-t01-pass-c.pdfveraPDF test suite 6-1-2-t01-fail-a.pdfNotes
This is a focused fix and can be reviewed independently from the aggregate integration PR.