sync: include missing PR806 follow-up commit in integration#24
Closed
vitormattos wants to merge 71 commits into
Closed
sync: include missing PR806 follow-up commit in integration#24vitormattos wants to merge 71 commits into
vitormattos wants to merge 71 commits into
Conversation
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
chore: merge getPages dedup fix into aggregate fork branch
Some PDFs include bytes before the %PDF- header while still using absolute xref offsets from the beginning of the file. The parser trimmed data before %PDF-, which shifted offsets and caused xref lookup failures. This manifested as an Invalid object reference error in the veraPDF corpus header case. Changes: - Keep original byte layout in RawDataParser::parseData - Add stricter trailer key matching for /Size /Root /Encrypt /Info /Prev - Add defensive handling in xref stream resolution when startxref is near, but not exactly at, the xref stream object - Add regression fixture and integration test Regression fixture: - samples/bugs/PullRequestInvalidObjectReference.pdf Test: - DocumentIssueFocusTest::testParseFileWithCompressedObjRefInXrefStream Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Some PDFs set startxref to the whitespace immediately before the xref keyword instead of the first letter of xref. The parser required an exact match and incorrectly switched to xref stream decoding, which then failed with Invalid object reference. Changes: - Skip PDF whitespace before checking startxref position - Use adjusted offset when decoding classic xref - Apply same whitespace tolerance for Unix line-ending detection - Tighten trailer key regexes to match /Size /Root /Encrypt /Info /Prev - Add regression fixture and integration test Regression fixture: - samples/bugs/PullRequestXrefWhitespaceStart.pdf Test: - DocumentIssueFocusTest::testParseFileWhenStartxrefPointsToLeadingWhitespace Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Fork/libresign parser fixes
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com> (cherry picked from commit 3e2a9c6)
…fixes reverse: integrate PR 805 into fork/libresign-parser-fixes
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com> (cherry picked from commit 1ae0081)
reverse: integrate PR 806 into fork/libresign-all-fixes
reverse: integrate PR 807 into fork/libresign-all-fixes (clean)
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com> (cherry picked from commit 3513040)
- Rename PullRequest807-pdf.js.pdf -> PullRequest807-pdfjs-xref-missing-keyword.pdf - Rename PullRequest808-pdf.js.pdf -> PullRequest807-pdfjs-xref-startxref-misaligned.pdf - Add *.pdf binary to .gitattributes to prevent CRLF conversion on Windows (fixes Undefined index: xref and Object list not found on Windows CI)
…ery-rebase Fork/fix/issue9252 xref recovery rebase
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…ll-fixes fix: recover malformed or missing startxref stanzas
# Conflicts: # src/Smalot/PdfParser/RawData/RawDataParser.php # tests/PHPUnit/Integration/DocumentIssueFocusTest.php
sync: merge PR810 fix into integration branch
sync: bring PR811 fix into integration/pdfjs-fixes
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Owner
Author
|
Closing this sync PR because integration/pdfjs-fixes was fully rebuilt from upstream master by exact replay of PRs smalot#795,smalot#796,smalot#797,smalot#798,smalot#799,smalot#800,smalot#801,smalot#804,smalot#805,smalot#806,smalot#807,smalot#808,smalot#810,smalot#811 and force-updated directly. |
vitormattos
force-pushed
the
integration/pdfjs-fixes
branch
from
ff2abc5 to
e786ad9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This sync PR applies the second commit currently present in upstream PR smalot#806 but absent from integration/pdfjs-fixes.\n\nApplied commit:\n- fix: recover repeated page refs in cyclic page trees\n\nWhy:\n- integration currently contains the first PR806 commit (cycle guard) but not this follow-up recovery change.\n- bringing this commit in avoids full branch rebuild and resolves the detected inconsistency.\n\nAfter merge, upstream PR smalot#809 will automatically reflect this update because it tracks integration/pdfjs-fixes.