Skip to content

Conversation

@jmank88
Copy link
Contributor

@jmank88 jmank88 commented Jan 6, 2026

@jmank88 jmank88 requested a review from dhaidashenko January 6, 2026 16:45
@jmank88 jmank88 requested a review from a team as a code owner January 6, 2026 16:45
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

👋 jmank88, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

pavel-raykov
pavel-raykov previously approved these changes Jan 6, 2026
@jmank88 jmank88 enabled auto-merge January 6, 2026 17:35
amit-momin
amit-momin previously approved these changes Jan 6, 2026
@jmank88 jmank88 force-pushed the PLEX-2111-chain-read-set branch from 06e6069 to 9e2e128 Compare January 6, 2026 21:19
trunk-io[bot]

This comment was marked as outdated.

@jmank88 jmank88 force-pushed the PLEX-2111-chain-read-set branch from 9e2e128 to d717022 Compare January 7, 2026 19:28
@jmank88 jmank88 dismissed stale reviews from amit-momin and pavel-raykov via 540dbe3 January 8, 2026 13:03
@jmank88 jmank88 changed the title core/services/workflows/v2: expand limited ChainSet method set core/services/workflows/v2: expand limited ChainRead method set Jan 8, 2026
@jmank88 jmank88 force-pushed the PLEX-2111-chain-read-set branch from 540dbe3 to 8fe9a7b Compare January 8, 2026 13:20
pavel-raykov
pavel-raykov previously approved these changes Jan 8, 2026
)

* Improve logging

* addd testcase name to cfg

* Refactor EVM Read Test

* remove redundant method

* fix linter

* go generate
trunk-io[bot]

This comment was marked as outdated.

trunk-io[bot]

This comment was marked as outdated.

dhaidashenko
dhaidashenko previously approved these changes Jan 12, 2026
amit-momin
amit-momin previously approved these changes Jan 12, 2026
@jmank88 jmank88 force-pushed the PLEX-2111-chain-read-set branch from b7aabd2 to 3589218 Compare February 2, 2026 23:24
@jmank88 jmank88 marked this pull request as ready for review February 2, 2026 23:31
amit-momin
amit-momin previously approved these changes Feb 2, 2026
@jmank88 jmank88 requested a review from Tofel February 3, 2026 14:09

var workflowsWg sync.WaitGroup
var successfulWorkflowRuns atomic.Int32
listenerCtx, messageChan, _ := t_helpers.StartBeholder(t, lggr, testEnv)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now that ChIP Ingress Test Sink PR has been merged I recommend using that instead of full ChIP stack.

If you do need to log all events, use GetLoggingPublishFn when starting the test sink instead of GetPublishFn. The former will save all events as JSON in a file.

If you do need to use the full stack for some reason you need to stop beholder in test clean up, because otherwise it will keep running on port 50051 and all tests that run after this one, which try to start the test sink will fail. Sink uses the same port as the real ChIP Ingress.

# Conflicts:
#	core/scripts/go.mod
#	deployment/go.mod
#	integration-tests/go.mod
#	integration-tests/load/go.mod
#	system-tests/lib/go.mod
#	system-tests/tests/go.mod
trunk-io[bot]

This comment was marked as outdated.

trunk-io[bot]

This comment was marked as outdated.

trunk-io[bot]

This comment was marked as outdated.

github.com/smartcontractkit/chainlink-protos/job-distributor v0.17.0
github.com/smartcontractkit/chainlink-testing-framework/framework v0.13.14-0.20260202230832-eb33f42188d1
github.com/smartcontractkit/chainlink-testing-framework/framework/components/dockercompose v0.1.19
github.com/smartcontractkit/chainlink-testing-framework/framework/components/dockercompose v0.1.18
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this downgrade is causing problems

HashWrangler
HashWrangler previously approved these changes Feb 3, 2026
@jmank88 jmank88 enabled auto-merge February 3, 2026 18:40
@jmank88 jmank88 requested a review from patrickhuie19 February 3, 2026 18:40
@jmank88 jmank88 requested a review from Tofel February 3, 2026 18:49
@cl-sonarqube-production
Copy link

@jmank88 jmank88 added this pull request to the merge queue Feb 3, 2026
Copy link

@trunk-io trunk-io bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Test Results: EVM Read Trigger Panic

Affected failures:

  1. Workflow Run: Integration Tests

What Broke

The CI failure is caused by an issue within one of the newly introduced EVM read operations or the refactoring of the onReadTrigger function to handle multiple test cases. Specifically, the requireEvent function now fetches the latest block number using HeaderByNumber, which is a new point of failure.

Proposed Fixes

Modify the onReadTrigger function in system-tests/tests/smoke/cre/evm/evmread/main.go to explicitly log any recovered panic errors using the workflow's logger, ensuring better visibility of test failures in CI logs.

In main.go:54

 \tdefer func() {
 \t	if r := recover(); r != nil {
+ \t		runtime.Logger().Error("onReadTrigger panicked", "recovered", r, "testCase", cfg.TestCase.String(), "workflow", cfg.WorkflowName)
 \t		err = fmt.Errorf("panic: %v", r)
 \t	}
 \t}()
Autofix Options

You can apply the proposed fixes directly to your branch. Try the following:

  • Comment /trunk stack-fix 9sZQ04CI to generate a stacked PR with the proposed fixes.
  • Use MCP in your IDE to fix the issue. Try Help me fix CI failures from 9sZQ04CI to get started.

Tip

Get Better Results: This CI job is not uploading test reports. Adding structured test reports enables more precise, test-level analysis with better root cause identification and more targeted fix recommendations.
👉🏻 Learn how to upload test results.

Merged via the queue into develop with commit a604ac4 Feb 3, 2026
223 of 225 checks passed
@jmank88 jmank88 deleted the PLEX-2111-chain-read-set branch February 3, 2026 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants