-
Notifications
You must be signed in to change notification settings - Fork 1.9k
core/services/workflows/v2: expand limited ChainRead method set #20725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 jmank88, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
|
I see you updated files related to
|
06e6069 to
9e2e128
Compare
9e2e128 to
d717022
Compare
540dbe3 to
8fe9a7b
Compare
b7aabd2 to
3589218
Compare
|
|
||
| var workflowsWg sync.WaitGroup | ||
| var successfulWorkflowRuns atomic.Int32 | ||
| listenerCtx, messageChan, _ := t_helpers.StartBeholder(t, lggr, testEnv) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now that ChIP Ingress Test Sink PR has been merged I recommend using that instead of full ChIP stack.
If you do need to log all events, use GetLoggingPublishFn when starting the test sink instead of GetPublishFn. The former will save all events as JSON in a file.
If you do need to use the full stack for some reason you need to stop beholder in test clean up, because otherwise it will keep running on port 50051 and all tests that run after this one, which try to start the test sink will fail. Sink uses the same port as the real ChIP Ingress.
# Conflicts: # core/scripts/go.mod # deployment/go.mod # integration-tests/go.mod # integration-tests/load/go.mod # system-tests/lib/go.mod # system-tests/tests/go.mod
core/scripts/go.mod
Outdated
| github.com/smartcontractkit/chainlink-protos/job-distributor v0.17.0 | ||
| github.com/smartcontractkit/chainlink-testing-framework/framework v0.13.14-0.20260202230832-eb33f42188d1 | ||
| github.com/smartcontractkit/chainlink-testing-framework/framework/components/dockercompose v0.1.19 | ||
| github.com/smartcontractkit/chainlink-testing-framework/framework/components/dockercompose v0.1.18 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this downgrade is causing problems
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Test Results: EVM Read Trigger Panic
Affected failures:
- Workflow Run: Integration Tests
What Broke
The CI failure is caused by an issue within one of the newly introduced EVM read operations or the refactoring of the onReadTrigger function to handle multiple test cases. Specifically, the requireEvent function now fetches the latest block number using HeaderByNumber, which is a new point of failure.
Proposed Fixes
Modify the onReadTrigger function in system-tests/tests/smoke/cre/evm/evmread/main.go to explicitly log any recovered panic errors using the workflow's logger, ensuring better visibility of test failures in CI logs.
In main.go:54
\tdefer func() {
\t if r := recover(); r != nil {
+ \t runtime.Logger().Error("onReadTrigger panicked", "recovered", r, "testCase", cfg.TestCase.String(), "workflow", cfg.WorkflowName)
\t err = fmt.Errorf("panic: %v", r)
\t }
\t}()Autofix Options
You can apply the proposed fixes directly to your branch. Try the following:
- Comment
/trunk stack-fix 9sZQ04CIto generate a stacked PR with the proposed fixes. - Use MCP in your IDE to fix the issue. Try
Help me fix CI failures from 9sZQ04CIto get started.
Tip
Get Better Results: This CI job is not uploading test reports. Adding structured test reports enables more precise, test-level analysis with better root cause identification and more targeted fix recommendations.
👉🏻 Learn how to upload test results.




https://smartcontract-it.atlassian.net/browse/PLEX-2111
Requires: