CRE Fix Chain Reads Tests in Response to Read Limits Enforcement #20762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dhaidashenko
commented
Jan 9, 2026
| defer func() { | ||
| if r := recover(); r != nil { | ||
| runtime.Logger().Error("recovered from panic", "recovered", r, "stack", string(debug.Stack())) | ||
| err = fmt.Errorf("panic: %v", r) |
Collaborator
Author
There was a problem hiding this comment.
Return error instead of panic to clean up logs
dhaidashenko
commented
Jan 9, 2026
| } | ||
| } | ||
| t.Logger.Error(fmt.Sprintf(format, args...)) | ||
| panic(fmt.Sprintf(format, args...)) // panic to stop execution |
Collaborator
Author
There was a problem hiding this comment.
panic here was redundat as require always calls FailNow, which panics to abort workflow execution
jmank88
approved these changes
Jan 9, 2026
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 3, 2026
* core/services/workflows/v2: expand limited ChainSet method set * CRE Fix Chain Reads Tests in Response to Read Limits Enforcement (#20762) * Improve logging * addd testcase name to cfg * Refactor EVM Read Test * remove redundant method * fix linter * go generate * bump common * Switch to ChipTestSink * Remove concurrent execution to avoid nonce race during workflow removal * Fix nolint --------- Co-authored-by: Dmytro Haidashenko <34754799+dhaidashenko@users.noreply.github.com> Co-authored-by: Dmytro Haidashenko <dmytro.haidashenko@smartcontract.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chain Read limits enforcement broke the CRE EVM Read Tests. To fix them, the test was split into smaller parts, each tested separately.