fix: HealthChecker.Register immediately populates cache when already running#21979
Closed
fix: HealthChecker.Register immediately populates cache when already running#21979
Conversation
Contributor
|
✅ No conflicts with other open PRs targeting |
Fletch153
force-pushed
the
fix-healthchecker-stale-cache
branch
from
fddfedc to
79ad808
Compare
Fletch153
force-pushed
the
fix-healthchecker-stale-cache
branch
2 times, most recently
from
2de53c9 to
fc680d0
Compare
Contributor
|
I see you updated files related to
|
Fletch153
force-pushed
the
fix-healthchecker-stale-cache
branch
2 times, most recently
from
7baf276 to
541f601
Compare
jmank88
previously approved these changes
Apr 14, 2026
Bump chainlink-common to v0.11.2-0.20260413215716-a931c3f2f162 (merge commit of smartcontractkit/chainlink-common#1976) to resolve stale cache in HealthChecker.Register() (CORE-2386).
Fletch153
force-pushed
the
fix-healthchecker-stale-cache
branch
from
541f601 to
4fc5880
Compare
…stale-cache # Conflicts: # core/scripts/go.sum # deployment/go.sum # go.mod # go.sum # integration-tests/go.sum # integration-tests/load/go.sum # system-tests/lib/go.sum # system-tests/tests/go.sum
…stale-cache # Conflicts: # core/scripts/go.mod # core/scripts/go.sum # deployment/go.mod # deployment/go.sum # go.mod # go.sum # integration-tests/go.mod # integration-tests/go.sum # integration-tests/load/go.mod # integration-tests/load/go.sum # system-tests/lib/go.mod # system-tests/lib/go.sum # system-tests/tests/go.mod # system-tests/tests/go.sum
…stale-cache # Conflicts: # core/scripts/go.mod # deployment/go.mod
Resolve conflict in integration-tests/load/go.mod: keep PR's chainlink-common version (a931c3f2f162) and take develop's chainlink-deployments-framework v0.95.0.
mchain0
previously approved these changes
Apr 16, 2026
jmank88
previously approved these changes
Apr 16, 2026
skudasov
previously approved these changes
Apr 16, 2026
…stale-cache # Conflicts: # core/scripts/go.mod # deployment/go.mod # integration-tests/go.mod # integration-tests/load/go.mod # system-tests/lib/go.mod
|
2 tasks
Collaborator
Author
|
Closing in favor of #22056 (same changes, fresh PR due to CI weirdness on this branch). |
auto-merge was automatically disabled
April 16, 2026 21:48
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
chainlink-commonto include the fix from smartcontractkit/chainlink-common#1976 (now merged), which resolves a stale cache issue inHealthChecker.Register()(CORE-2386).When a service was registered with an already-running
HealthChecker, its health state was absent fromIsHealthy()/IsReady()for up to 15 seconds. The fix ensures newly registered services are immediately visible in health reports.Changes
go.mod/go.sum— bumpchainlink-commontov0.11.2-0.20260413215716-a931c3f2f162(merge commit of chainlink-common#1976)chainlink-protos/cre/goalso bumped as a transitive dependency requirement from the newchainlink-commonTest plan
go build ./...passes