Skip to content

fix: HealthChecker.Register immediately populates cache when already running#22056

Closed
Fletch153 wants to merge 12 commits intodevelopfrom
fix/healthchecker-register-cache
Closed

fix: HealthChecker.Register immediately populates cache when already running#22056
Fletch153 wants to merge 12 commits intodevelopfrom
fix/healthchecker-register-cache

Conversation

@Fletch153
Copy link
Copy Markdown
Collaborator

Summary

Bumps chainlink-common to include the fix from smartcontractkit/chainlink-common#1976 (now merged), which resolves a stale cache issue in HealthChecker.Register() (CORE-2386).

When a service was registered with an already-running HealthChecker, its health state was absent from IsHealthy() / IsReady() for up to 15 seconds. The fix ensures newly registered services are immediately visible in health reports.

Changes

  • go.mod / go.sum — bump chainlink-common to v0.11.2-0.20260413215716-a931c3f2f162 (merge commit of chainlink-common#1976)
  • chainlink-protos/cre/go also bumped as a transitive dependency requirement from the new chainlink-common

Test plan

  • go build ./... passes
  • chainlink-common#1976 merged with passing tests

Replaces #21979.

Bump chainlink-common to v0.11.2-0.20260413215716-a931c3f2f162
(merge commit of smartcontractkit/chainlink-common#1976) to resolve
stale cache in HealthChecker.Register() (CORE-2386).
…stale-cache

# Conflicts:
#	core/scripts/go.sum
#	deployment/go.sum
#	go.mod
#	go.sum
#	integration-tests/go.sum
#	integration-tests/load/go.sum
#	system-tests/lib/go.sum
#	system-tests/tests/go.sum
…stale-cache

# Conflicts:
#	core/scripts/go.mod
#	core/scripts/go.sum
#	deployment/go.mod
#	deployment/go.sum
#	go.mod
#	go.sum
#	integration-tests/go.mod
#	integration-tests/go.sum
#	integration-tests/load/go.mod
#	integration-tests/load/go.sum
#	system-tests/lib/go.mod
#	system-tests/lib/go.sum
#	system-tests/tests/go.mod
#	system-tests/tests/go.sum
…stale-cache

# Conflicts:
#	core/scripts/go.mod
#	deployment/go.mod
Resolve conflict in integration-tests/load/go.mod: keep PR's
chainlink-common version (a931c3f2f162) and take develop's
chainlink-deployments-framework v0.95.0.
…stale-cache

# Conflicts:
#	core/scripts/go.mod
#	deployment/go.mod
#	integration-tests/go.mod
#	integration-tests/load/go.mod
#	system-tests/lib/go.mod
@github-actions
Copy link
Copy Markdown
Contributor

👋 Fletch153, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions
Copy link
Copy Markdown
Contributor

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 16, 2026

✅ No conflicts with other open PRs targeting develop

@trunk-io
Copy link
Copy Markdown

trunk-io Bot commented Apr 16, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

Failed Test Failure Summary Logs
Test_CachedInMemoryDataSourceErrHandling The test failed due to a panic caused by a missing return value in the ExecuteRun function. Logs ↗︎
Test_CachedInMemoryDataSourceErrHandling/test_normal_cache_updater_fail_recovery The test failed because the function 'ExecuteRun' did not return a value as expected, causing a panic. Logs ↗︎
Test_CCIPPureTokenTransfer_EVM2Sui_BurnMintTokenPool The test failed during a coin transfer operation, indicating an issue with the transfer process or the coin involved. Logs ↗︎

View Full Report ↗︎Docs

jmank88
jmank88 previously approved these changes Apr 17, 2026
pavel-raykov
pavel-raykov previously approved these changes Apr 17, 2026
@pavel-raykov pavel-raykov added this pull request to the merge queue Apr 17, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 17, 2026
@Fletch153 Fletch153 added this pull request to the merge queue Apr 17, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Apr 17, 2026
…stale-cache

# Conflicts:
#	integration-tests/load/go.mod
@Fletch153 Fletch153 dismissed stale reviews from pavel-raykov and jmank88 via e4cbb33 April 17, 2026 14:26
@cl-sonarqube-production
Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@Fletch153 Fletch153 enabled auto-merge April 17, 2026 15:07
@Fletch153
Copy link
Copy Markdown
Collaborator Author

Closing — superseded. Develop's chainlink-common is now at v0.11.2-0.20260417081611-8bdbd9f45629, which already includes the HealthChecker.Register fix from chainlink-common#1976. The effective diff of this PR vs develop is empty; no further bump needed.

@Fletch153 Fletch153 closed this Apr 17, 2026
auto-merge was automatically disabled April 17, 2026 16:50

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants