Fix Go dependency download running in wrong directory in devenv-compat.yml - #23550
Merged
Conversation
The 'Download Go dependencies' step ran 'go mod download' with no
working-directory, so it executed against the repo root's go.mod
instead of ${{ env.WORKING_DIR }} (devenv), unlike every other run
step in this job. Set up Go via go-version-file: devenv/go.mod, but
go mod download then read the root go.mod -- which requires a newer
Go version than devenv/go.mod does, so the step failed with
'go.mod requires go >= 1.26.6 (running go 1.26.5)' as soon as the
two go.mod files' versions diverged (root bumped by #23510).
Scoping the download to the same working directory as setup-go's
version file fixes the immediate failure and matches every other
step in this job.
product-security-plaid-production
Bot
requested review from
erikburt and
kalverra
August 25, 2026 20:43
Contributor
|
👋 HashWrangler, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
Contributor
|
✅ No conflicts with other open PRs targeting |
Keeps devenv's go directive in sync with the root go.mod (bumped in #23510), now that the download step actually reads devenv/go.mod as intended. Verified 'go build ./...' succeeds under golang:1.26.6-bookworm.
|
Tofel
approved these changes
Aug 26, 2026
pavel-raykov
approved these changes
Aug 26, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
working-directory: ${{ env.WORKING_DIR }}to the "Download Go dependencies" step in.github/workflows/devenv-compat.yml.devenv/go.mod'sgodirective1.26.5->1.26.6.Why
The "Download Go dependencies" step ran
go mod downloadwith no working-directory set, so it executed against the repo root'sgo.modinstead of${{ env.WORKING_DIR }}(devenv) -- every otherrun:step in this job already scopes toWORKING_DIR, this one was the outlier."Set up Go" resolves its version from
devenv/go.mod(go-version-file), butgo mod downloadthen read the rootgo.mod, which requires a newer Go version. Root's directive was bumped1.26.5->1.26.6in #23510;devenv/go.modwas still1.26.5. Once the two diverged, this step started failing:This is what's currently failing the Data Feeds v1 Upgrade Test job on the v2.62.0-rc.0 canary run -- unrelated to the curl-pin PRs (#23530, #23531).
With the working-directory fix alone, the download step now correctly reads
devenv/go.mod(1.26.5) and would pass -- but that leavesdevenvon an older Go directive than root for no reason. Bumpingdevenv/go.modto1.26.6keeps the two in sync going forward.Verification
python3 -c "import yaml; yaml.safe_load(open('.github/workflows/devenv-compat.yml'))"-- valid YAML.run:step in this job ("Run compat test", "Attach CI Summary", "Collect Docker container logs") already setsworking-directory: ${{ env.WORKING_DIR }}; this brings the download step in line.go build ./...indevenv/succeeds undergolang:1.26.6-bookwormwith the bumped directive.