Skip to content

Ensure cap ID - #23594

Merged
vreff merged 3 commits into
developfrom
ensure-cap-id
Aug 31, 2026
Merged

Ensure cap ID#23594
vreff merged 3 commits into
developfrom
ensure-cap-id

Conversation

@vreff

@vreff vreff commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

No description provided.

vreff and others added 2 commits August 31, 2026 11:12
* ensure capability ID

* Bump test-scripts runner to fix disk space overrun

core-scripts-tests ran on plain ubuntu-latest (2-core/14GB disk) and
failed linking core/scripts/cre/reconciler.test with 'No space left on
device'. core/scripts pulls in heavy CGO-linked deps (duckdb, wasmtime,
librdkafka) that don't fit the default runner's disk alongside the rest
of the build.

Clean Go Tidy & Generate, doing similarly heavy Go work in this same
file, already uses ubuntu22.04-8cores-32GB and passed in this run --
matching that runner size here instead of adding cleanup steps.

---------

Co-authored-by: HashWrangler <12961024+HashWrangler@users.noreply.github.com>
@vreff
vreff requested a review from a team as a code owner August 31, 2026 17:04
@vreff vreff changed the title Ensure cap Ensure cap ID Aug 31, 2026
@github-actions

Copy link
Copy Markdown
Contributor

👋 vreff, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions

Copy link
Copy Markdown
Contributor

✅ No conflicts with other open PRs targeting develop

@github-actions

Copy link
Copy Markdown
Contributor

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@trunk-io

trunk-io Bot commented Aug 31, 2026

Copy link
Copy Markdown

Static BadgeStatic BadgeStatic Badge

Failed Test Failure Summary Logs
Test_DeleteWorkflowSpecs The test failed due to a database deadlock error during the deletion of workflow specifications. Logs ↗︎

View Full Report ↗︎Docs

@cl-sonarqube-production

Copy link
Copy Markdown

@vreff
vreff added this pull request to the merge queue Aug 31, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 31, 2026
@vreff
vreff added this pull request to the merge queue Aug 31, 2026
Merged via the queue into develop with commit ee9db3b Aug 31, 2026
226 of 227 checks passed
@vreff
vreff deleted the ensure-cap-id branch August 31, 2026 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants