Skip to content

Serve static files and the API on a single port#403

Merged
j16r merged 1 commit into
masterfrom
feature/serve_on_only_one_port
Jul 9, 2018
Merged

Serve static files and the API on a single port#403
j16r merged 1 commit into
masterfrom
feature/serve_on_only_one_port

Conversation

@j16r

@j16r j16r commented Jul 6, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

No description provided.

@j16r j16r force-pushed the feature/serve_on_only_one_port branch from 9311cb4 to 81a8f79 Compare July 6, 2018 22:31
@codecov

codecov Bot commented Jul 6, 2018 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #403 into master will decrease coverage by 0.17%.
The diff coverage is 30.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #403      +/-   ##
==========================================
- Coverage   81.38%   81.21%   -0.18%     
==========================================
  Files          52       52              
  Lines        3841     3832       -9     
==========================================
- Hits         3126     3112      -14     
- Misses        434      439       +5     
  Partials      281      281
Impacted Files Coverage Δ
store/config.go 78.94% <ø> (ø) ⬆️
store/presenters/presenters.go 84.57% <ø> (-0.22%) ⬇️
cmd/client.go 72.81% <0%> (+0.22%) ⬆️
web/router.go 81.63% <33.33%> (-6.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 392c8cd...86d9577. Read the comment docs.

thodges-gh
thodges-gh previously approved these changes Jul 6, 2018
View reviewed changes

@thodges-gh thodges-gh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@j16r j16r requested a review from rupurt July 6, 2018 22:43
@j16r j16r force-pushed the feature/serve_on_only_one_port branch 3 times, most recently from 4883b57 to 1f5f8ee Compare July 6, 2018 23:22
@j16r j16r mentioned this pull request Jul 6, 2018
Merged
@j16r j16r force-pushed the feature/serve_on_only_one_port branch 4 times, most recently from 8a5112e to 824001b Compare July 7, 2018 00:54
@rupurt

rupurt commented Jul 9, 2018

Copy link
Copy Markdown
Contributor

@j16r love the approach by using the not found fallback!

rupurt
rupurt suggested changes Jul 9, 2018
View reviewed changes
Comment thread cmd/client.go Outdated

@rupurt rupurt Jul 9, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you feel about calling these api variables server now?

Comment thread gui/src/api.js Outdated

@rupurt rupurt Jul 9, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to keep this so that we can use webpack dev server during development which serves the assets from :3000

@j16r j16r Jul 9, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed: will use CHAINLINK_PORT

Comment thread internal/cltest/cltest.go Outdated

@rupurt rupurt Jul 9, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you feel about renaming this to newServer

Comment thread store/config.go Outdated

@rupurt rupurt Jul 9, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to keep this so that requests from webpack dev server assets works in development. 6689 should be changed to 6688

Comment thread web/cors_test.go Outdated

@rupurt rupurt Jul 9, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep these. Port 6689 should be updated to 6688

Comment thread web/router.go Outdated

@rupurt rupurt Jul 9, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep this for webpack dev server

@j16r j16r force-pushed the feature/serve_on_only_one_port branch from 824001b to 54032fe Compare July 9, 2018 16:44
rupurt
rupurt suggested changes Jul 9, 2018
View reviewed changes
Comment thread internal/cltest/cltest.go Outdated

@rupurt rupurt Jul 9, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apiEngine -> engine

@j16r j16r force-pushed the feature/serve_on_only_one_port branch from 54032fe to 86d9577 Compare July 9, 2018 17:14
@rupurt

rupurt commented Jul 9, 2018

Copy link
Copy Markdown
Contributor

Swoit! ⚽️

@j16r j16r merged commit cce5a78 into master Jul 9, 2018
@j16r j16r deleted the feature/serve_on_only_one_port branch July 9, 2018 18:39
@snyk-bot snyk-bot mentioned this pull request Nov 11, 2020
Open
pavel-raykov pushed a commit that referenced this pull request Jun 14, 2024
@jmank88 @krehermann
pkg/sqlutil: switch TimeoutHook argument to func for dynamic reconfig…
2bc22a6 
…uration; add TransactDataSource (#403)

Co-authored-by: krehermann <keith.rehermann@smartcontract.com>
asoliman92 pushed a commit that referenced this pull request Jul 31, 2024
@mateusz-sekara
Update publish.yml according to the docs (#403)
49b3843
alecgard pushed a commit that referenced this pull request Feb 6, 2025
@cawthorne @alecgard
Fix Capitalization nits (#403)
d86932f
@nadahalli nadahalli mentioned this pull request Jul 7, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thodges-gh thodges-gh thodges-gh left review comments
+1 more reviewer
@rupurt rupurt rupurt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@j16r @rupurt @thodges-gh