Revise SDL-0273 Webengine projection mode. - #1023
Merged
theresalech merged 3 commits intoJun 8, 2020
Merged
Conversation
AByzhynar
force-pushed
the
webengine-projection-revisions
branch
from
May 29, 2020 11:29
7fcfd21 to
e3b562f
Compare
Contributor
Author
|
@theresalech Please review the revision. All comments from #912 (comment) were considered. Thank you. |
Contributor
|
Hi @AByzhynar, once the Steering Committee has voted on SDL 0273, I'll review this PR. Thanks! |
theresalech
suggested changes
Jun 3, 2020
theresalech
left a comment
theresalech
left a comment
Contributor
There was a problem hiding this comment.
Hi @AByzhynar, I've left a few comments for your review. Please let me know if you have any questions or concerns with addressing. Thank you!
theresalech
suggested changes
Jun 4, 2020
theresalech
left a comment
theresalech
left a comment
Contributor
There was a problem hiding this comment.
@AByzhynar this is minor, but one set of backticks was missed. Can you please add?
theresalech
approved these changes
Jun 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This proposal is created based on the discussion in #767.
The revision is created based on the discussion in #912
It extends SDL-0240 - WebEngine support for SDL JavaScript to allow using the WebEngine app's web view for the HMI in addition to the other available SDL templates.