Skip to content

SDL 0273 WebEngine Projection Mode - Revisions - #952

Merged
theresalech merged 8 commits into
masterfrom
unknown repository
Mar 25, 2020
Merged

SDL 0273 WebEngine Projection Mode - Revisions#952
theresalech merged 8 commits into
masterfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Feb 27, 2020

Copy link
Copy Markdown

This proposal is created based on discussion in #767.
It extends SDl-0240 - WebEngine support for SDL JavaScript to allow using the WebEngine app's web view for the HMI in addition to the other available SDL templates.

@ghost

ghost commented Feb 28, 2020

Copy link
Copy Markdown
Author

(Comment 1) Add "The app HMI type PROJECTION should be enabled for in-vehicle apps. When in-vehicle apps with this HMI type are activated, the HMI should make the web page of this app visible on the screen. This web page will become the main window of the application."

Done. Due comment 3 and comment 10 I slightly changed this statement in the revision. See line 59-60. The major point of comment 1 was to add "in-vehicle apps" to avoid confusing. @JackLivio can confirm.

(Comment 3) Use HMI type in addition to PROJECTION, and use PM's suggestion for renaming

The agreement was to use a different name than PROJECTION. The revision's suggestion is WEB_VIEW as the new HMI type and template name (matching revision for comment 10).

(Comment 4) Add to motivation section, including: [...]

Done. It's slightly modified to describe the background of the question.

(Comment 9) Specify that when an app is deactivated into HMI level NONE, the connection to Core can stay open as long as there is a way for the HMI to be able to unregister and disconnect an app in case of performance issues. Additionally, add ApplicationExitReason::RESOURCE_CONTRAINT to HMI API and AppInterfaceUnregisteredReason::RESOURCE_CONSTRIAINT to MOBILE API.

Done

(Comment 10) Use template based approach, with name WEB_VIEW.

Done

@ghost

ghost commented Feb 28, 2020

Copy link
Copy Markdown
Author

@theresalech the PR is ready for review.

@Jack-Byrne

Copy link
Copy Markdown
Contributor

@kshala-ford Regarding these lines:

A new App HMI type WEB_VIEW should be added for in-vehicle WebEngine apps. This HMI type specifies that the application's initial template should be set to WEB_VIEW instead of DEFAULT.
When in-vehicle apps with this HMI type are activated, the HMI should make the web page of this app visible on the screen. This web page will become the main window of the application.

My understanding was the web page would be embedded in a template that acts as the "main window". In other words the rendered html would be a child component of the WEB_VIEW template.

I think this line is also related to my confusion:

If the WEB_VIEW template is currently active, the window capabilities change as the application is presenting content using the web document.

I thought the capabilities of the template would be the HMI fields that are outside of the embedded html portion of the WEB_VIEW template. The capabilities would not change based on what html is being rendered on screen.

@theresalech theresalech left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kshala-ford - I've left a few comments. Please review and let me know if you have any questions, thanks!

Comment thread proposals/0273-webengine-projection-mode.md Outdated
Comment thread proposals/0273-webengine-projection-mode.md Outdated
Comment thread proposals/0273-webengine-projection-mode.md Outdated
Comment thread proposals/0273-webengine-projection-mode.md Outdated
Comment thread proposals/0273-webengine-projection-mode.md Outdated
Comment thread proposals/0273-webengine-projection-mode.md Outdated
Comment thread proposals/0273-webengine-projection-mode.md Outdated
Comment thread proposals/0273-webengine-projection-mode.md Outdated
@theresalech

Copy link
Copy Markdown
Contributor

@AByzhynar, thank you! Are you going to be taking over authoring this proposal in Kujtim's absence? If so, can someone from the Ford team please confirm they are aware and approve? We'll then need you to please add your name as a co-author in Line 4, and I believe we are still awaiting an answer to Jack's comment here.

Comment thread proposals/0273-webengine-projection-mode.md Outdated
@ghost

ghost commented Mar 10, 2020

Copy link
Copy Markdown
Author

@JackLivio

My understanding was the web page would be embedded in a template that acts as the "main window". In other words the rendered html would be a child component of the WEB_VIEW template

Please have a look at my latest suggested change. From an app perspective you would change your main window’s template to WEB_VIEW. The HMI should make the web page of the app visible in the area of the main window. That’s the requirement. The way how the HMI implements it is up to the OEM. Embedding the web page in a template is one way but this shouldn’t be part of the proposal.

I thought the capabilities of the template would be the HMI fields that are outside of the embedded html portion of the WEB_VIEW template. The capabilities would not change based on what html is being rendered on screen.

I’m sorry for the confusion. I think I understand your concern. Obviously the capabilities don’t change while the template is active. I’m referring to the event when the app changes the main window to this template. Then the capabilities may change as text fields or SDL soft buttons won’t be visible on the template. Of course it depends all on the IVI and what fields remain visible. Most likely the main fields won’t be available but the template title or the menu name might be.

@JackLivio @theresalech please note that in the current status of this proposal we shouldn’t do feature discussions. If the PR contains all revisions then please mark the PR review ready. Discussing the content should be with all members of the SDLC not only between the authors and the PM. Thanks!

@Jack-Byrne

Copy link
Copy Markdown
Contributor

@kshala-ford Thank you for the clarification. I think we are on the same page.

@theresalech

Copy link
Copy Markdown
Contributor

@AByzhynar, please advise if you are going to be taking over authoring this proposal in Kujtim's absence. If so, can someone from the Ford team please confirm they are aware and approve? We'll then need you to please add your name as a co-author in Line 4. Thank you!

@AByzhynar

AByzhynar commented Mar 13, 2020

Copy link
Copy Markdown
Contributor

@AByzhynar, please advise if you are going to be taking over authoring this proposal in Kujtim's absence. If so, can someone from the Ford team please confirm they are aware and approve? We'll then need you to please add your name as a co-author in Line 4. Thank you!

@theresalech Done in 2d96c89
I and Markos Rapitis will be additional co-authors while Kujtim is absent.

@mrapitis Please confirm that we both will be co-authors.

@mrapitis

Copy link
Copy Markdown
Contributor

@theresalech both @AByzhynar and I will be co-authors of this proposal. thanks!

@theresalech
theresalech merged commit c52347a into smartdevicelink:master Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants