fix(cms): support keyboard selection of content templates - #91
Merged
Conversation
Co-Authored-By: Codex <noreply@openai.com>
snowopsdev
marked this pull request as ready for review
September 5, 2026 03:54
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
E2E-005: the template cards on New content declare a radio group, but pressing an arrow key does not move focus or select the adjacent template. Every card also occupies a separate Tab stop, so the controls do not behave as the radio group they present to keyboard users.
Why This Change Was Made
The cards now keep one Tab stop and support wrapping arrow-key navigation. Home and End move to the first and last template. Focus and the selected template move together, while native button activation continues to support Enter and Space.
User Impact
Keyboard users can choose a content template using the expected radio-group controls and then continue to keyword or topic entry. Mouse selection and the visual layout stay the same. The change is limited to the template group; other tab controls and screen-reader behavior are outside this repair's verified coverage.
Evidence
56c0731: after ArrowRight, the next template reportedaria-checked=falseand did not receive focus.tabIndex=0. It passes after the fix and covers selection, focus, a single Tab stop, wrapping arrows, Home and End.git diff --checkpassed. Tests used mock mode with no paid-provider calls or production writes. This draft awaits hosted CI and combined campaign verification.