Skip to content

spike: support node@16 lts - #2343

Closed
ghost wants to merge 7 commits into
masterfrom
feat/node-16
Closed

spike: support node@16 lts#2343
ghost wants to merge 7 commits into
masterfrom
feat/node-16

Conversation

@ghost

@ghost ghost commented Nov 8, 2021

Copy link
Copy Markdown

Node 16 LTS was released at the end of October 2021. It will work with existing CLI releases, but we aren't explicity testing it. This PR adds Node 16 to our CI pipeline to ensure everything we test for continues working.

To Do

After Merge

  1. Deprecate Node 10
  2. Upgrade to npm 8
  3. Upgrade binaries

npm 8 and Node 10

Node 16 ships with npm 8. npm 8 dropped support for Node 10 and fails if it's detected. This means we cannot run builds and tests against a Node 10 environment. Node 10 is deprecated and is no longer maintained.

So to properly support Node 16 in the future, we'll need to drop Node 10. For now, we can downgrade to npm 7.

@ghost ghost mentioned this pull request Nov 8, 2021
@github-actions

github-actions Bot commented Nov 8, 2021

Copy link
Copy Markdown
Contributor
Warnings
⚠️

Since the CLI is unifying on a standard and improved tooling, we're starting to migrate old-style imports and exports to ES6 ones.
A file you've modified is using either module.exports or require(). If you can, please update them to ES6 import syntax and export syntax.
Files found:

  • src/cli/index.ts
Messages
📖 You are modifying something in test/smoke directory, yet you are not on the branch starting with smoke/. You can prefix your branch with smoke/ and Smoke tests will trigger for this PR.

Generated by 🚫 dangerJS against ff82a3c

@ghost
ghost force-pushed the feat/node-16 branch from c864ef2 to 450fbe1 Compare November 8, 2021 15:48
@ghost ghost changed the title feat: use node@16 lts for binaries feat: support node@16 lts Nov 8, 2021
@ghost
ghost force-pushed the feat/node-16 branch 6 times, most recently from 22b50ab to fc0934f Compare November 8, 2021 19:12
@ghost
ghost force-pushed the feat/node-16 branch from fc0934f to c6abe0c Compare November 8, 2021 19:16
@ghost
ghost force-pushed the feat/node-16 branch from c6abe0c to 6f843f9 Compare November 9, 2021 12:52
@ghost
ghost force-pushed the feat/node-16 branch from 6f843f9 to ff82a3c Compare November 9, 2021 13:01
@ghost ghost mentioned this pull request Nov 9, 2021
@ghost

ghost commented Nov 30, 2021

Copy link
Copy Markdown

This PR modifies files linked to issues tracked in Stepsize.

You might want to review their status, priority, and scope.

 Mention [stepsize] in a comment if you'd like to report some technical debt. See examples here.

@darscan
darscan deleted the feat/node-16 branch January 20, 2023 18:01
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants