spike: support node@16 lts - #2343
Closed
ghost wants to merge 7 commits into
Closed
Conversation
Contributor
|
ghost
force-pushed
the
feat/node-16
branch
6 times, most recently
from
November 8, 2021 19:12
22b50ab to
fc0934f
Compare
|
This PR modifies files linked to issues tracked in Stepsize. You might want to review their status, priority, and scope.
|
This was referenced Jan 16, 2022
This was referenced Jan 17, 2022
This was referenced Feb 1, 2022
This was referenced Sep 22, 2022
This was referenced Sep 24, 2022
This was referenced Sep 26, 2022
This was referenced Oct 1, 2022
This was referenced Oct 3, 2022
This was referenced Feb 19, 2023
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node 16 LTS was released at the end of October 2021. It will work with existing CLI releases, but we aren't explicity testing it. This PR adds Node 16 to our CI pipeline to ensure everything we test for continues working.
To Do
After Merge
npm 8 and Node 10
Node 16 ships with npm 8. npm 8 dropped support for Node 10 and fails if it's detected. This means we cannot run builds and tests against a Node 10 environment. Node 10 is deprecated and is no longer maintained.
So to properly support Node 16 in the future, we'll need to drop Node 10. For now, we can downgrade to npm 7.