fix: ignore analytics request failures - #2346
Merged
1 commit merged intoNov 8, 2021
Merged
Conversation
ghost
mentioned this pull request
Avishagp
approved these changes
Nov 8, 2021
ghost
marked this pull request as ready for review
November 8, 2021 15:25
ghost
requested review from
a team,
admons,
alexandruz,
florindumitrascu,
mika-bar,
muscar and
tonidevine1
November 8, 2021 15:25
ghost
deleted the
fix/ignore-analytics-failures
branch
November 8, 2021 16:00
This was referenced Jan 16, 2022
This was referenced Feb 1, 2022
This was referenced Sep 22, 2022
This was referenced Sep 24, 2022
This was referenced Sep 26, 2022
This was referenced Oct 1, 2022
This was referenced Oct 3, 2022
This was referenced Feb 19, 2023
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up from #2343
We don't want to fail on analytics requests. Previously these failures were being logged as "unhandled rejections" which was picked up bt #2343 as Node 15 onwards now fails with Exit Code 1 on unhandled rejections.
We already have a try/catch which attempts to ignore any thrown errors in
postAnalytics. However, since we didn'tawaitthemakeRequestcall, any errors from the request were being forwarded to the caller rather than thrown and ignored by thecatchblock withinpostAnalytics. This PR fixes that.