fix: make sure we are not combining chunks when only one chunk provided#334
Merged
mkopcins merged 8 commits intosoftware-mansion:mainfrom Jun 2, 2025
Merged
Conversation
mkopcins
approved these changes
May 27, 2025
Collaborator
|
@MateWW can you resolve conflicts? |
## Description * Fix Heading in `Quickstart - Running Llama` and make it compatible * Update link to ready-made models in table of contents * Remove unnecessary horizontal bars from `Quickstart - Running Llama` * Rephrase section with minimal supported versions * Make more visible names of examples in `Example` section * And emoji to warning section and unlink from table of content as it is a part of the `Example` section ### Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [x] Documentation update (improves or adds clarity to existing documentation) ### Tested on - [x] iOS - [x] Android ### Testing instructions No testing necessary. ### Screenshots Not applicable ### Related issues Not applicable ### Checklist - [x] I have performed a self-review of my code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have updated the documentation accordingly - [ ] My changes generate no new warnings ### Additional notes <!-- Include any additional information, assumptions, or context that reviewers might need to understand this PR. --> --------- Co-authored-by: Jakub Gonera <38468585+JakubGonera@users.noreply.github.com>
software-mansion#341) ## Description Add section about using different recognizers. ### Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [x] Documentation update (improves or adds clarity to existing documentation) ### Tested on - [ ] iOS - [ ] Android ### Testing instructions <!-- Provide step-by-step instructions on how to test your changes. Include setup details if necessary. --> ### Screenshots <!-- Add screenshots here, if applicable --> ### Related issues <!-- Link related issues here using #issue-number --> ### Checklist - [x] I have performed a self-review of my code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have updated the documentation accordingly - [ ] My changes generate no new warnings ### Additional notes <!-- Include any additional information, assumptions, or context that reviewers might need to understand this PR. -->
## Description This PR introduces new structure of repository: - apps directory - contains standalone applications which are using package from `packages` directory - packages - contains react native executorch library ### Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation update (improves or adds clarity to existing documentation) ### Tested on - [x] iOS - [x] Android ### Testing instructions <!-- Provide step-by-step instructions on how to test your changes. Include setup details if necessary. --> ### Screenshots <!-- Add screenshots here, if applicable --> ### Related issues <!-- Link related issues here using #issue-number --> ### Checklist - [ ] I have performed a self-review of my code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have updated the documentation accordingly - [ ] My changes generate no new warnings ### Additional notes <!-- Include any additional information, assumptions, or context that reviewers might need to understand this PR. --> --------- Co-authored-by: pweglik <36445788+pweglik@users.noreply.github.com>
software-mansion#343) ## Description We don't use it anywhere in the library - artifact of the past. ### Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation update (improves or adds clarity to existing documentation) ### Tested on - [x] iOS - [ ] Android ### Checklist - [x] I have performed a self-review of my code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have updated the documentation accordingly - [x] My changes generate no new warnings
Member
|
@mkopcins I rebased, feel free to merge |
msluszniak
reviewed
May 28, 2025
msluszniak
approved these changes
May 29, 2025
mkopcins
added a commit
that referenced
this pull request
Jun 5, 2025
…ed (#334) ## Description <!-- Provide a concise and descriptive summary of the changes implemented in this PR. --> When I tried to use new whisper release I've noticed that it's for some reason falling into infinite `generating` state. I've done investigation and it turned out that simply I was recording single word what was not longer than 1 chunk. In result it was causing some silent error which prevented model from being triggered. This guard resolves the issue for me. ### Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation update (improves or adds clarity to existing documentation) ### Tested on - [x] iOS - [ ] Android ### Testing instructions <!-- Provide step-by-step instructions on how to test your changes. Include setup details if necessary. --> I cannot share the code but just simply provide very short waveform to `transcribe` method of `useSpeechToText` hook ### Screenshots <!-- Add screenshots here, if applicable --> | Before | After | | --- | --- | | <video src="https://github.com/user-attachments/assets/41754d72-31bb-457a-90ec-f6e4447d0fd8" /> | <video src="https://github.com/user-attachments/assets/03df1a87-d3c1-4ba7-8aaa-f8a47cd91613" /> | ### Checklist - [x] I have performed a self-review of my code - [x] My changes generate no new warnings ### Additional notes <!-- Include any additional information, assumptions, or context that reviewers might need to understand this PR. --> --------- Co-authored-by: Mateusz Kopcinski <120639731+mkopcins@users.noreply.github.com> Co-authored-by: Mateusz Sluszniak <56299341+msluszniak@users.noreply.github.com> Co-authored-by: Jakub Gonera <38468585+JakubGonera@users.noreply.github.com> Co-authored-by: Norbert Klockiewicz <Nklockiewicz12@gmail.com> Co-authored-by: pweglik <36445788+pweglik@users.noreply.github.com>
mkopcins
added a commit
that referenced
this pull request
Jun 5, 2025
…ed (#334) ## Description <!-- Provide a concise and descriptive summary of the changes implemented in this PR. --> When I tried to use new whisper release I've noticed that it's for some reason falling into infinite `generating` state. I've done investigation and it turned out that simply I was recording single word what was not longer than 1 chunk. In result it was causing some silent error which prevented model from being triggered. This guard resolves the issue for me. ### Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation update (improves or adds clarity to existing documentation) ### Tested on - [x] iOS - [ ] Android ### Testing instructions <!-- Provide step-by-step instructions on how to test your changes. Include setup details if necessary. --> I cannot share the code but just simply provide very short waveform to `transcribe` method of `useSpeechToText` hook ### Screenshots <!-- Add screenshots here, if applicable --> | Before | After | | --- | --- | | <video src="https://github.com/user-attachments/assets/41754d72-31bb-457a-90ec-f6e4447d0fd8" /> | <video src="https://github.com/user-attachments/assets/03df1a87-d3c1-4ba7-8aaa-f8a47cd91613" /> | ### Checklist - [x] I have performed a self-review of my code - [x] My changes generate no new warnings ### Additional notes <!-- Include any additional information, assumptions, or context that reviewers might need to understand this PR. --> --------- Co-authored-by: Mateusz Kopcinski <120639731+mkopcins@users.noreply.github.com> Co-authored-by: Mateusz Sluszniak <56299341+msluszniak@users.noreply.github.com> Co-authored-by: Jakub Gonera <38468585+JakubGonera@users.noreply.github.com> Co-authored-by: Norbert Klockiewicz <Nklockiewicz12@gmail.com> Co-authored-by: pweglik <36445788+pweglik@users.noreply.github.com>
mkopcins
added a commit
that referenced
this pull request
Oct 15, 2025
…ed (#334) ## Description <!-- Provide a concise and descriptive summary of the changes implemented in this PR. --> When I tried to use new whisper release I've noticed that it's for some reason falling into infinite `generating` state. I've done investigation and it turned out that simply I was recording single word what was not longer than 1 chunk. In result it was causing some silent error which prevented model from being triggered. This guard resolves the issue for me. ### Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation update (improves or adds clarity to existing documentation) ### Tested on - [x] iOS - [ ] Android ### Testing instructions <!-- Provide step-by-step instructions on how to test your changes. Include setup details if necessary. --> I cannot share the code but just simply provide very short waveform to `transcribe` method of `useSpeechToText` hook ### Screenshots <!-- Add screenshots here, if applicable --> | Before | After | | --- | --- | | <video src="https://github.com/user-attachments/assets/41754d72-31bb-457a-90ec-f6e4447d0fd8" /> | <video src="https://github.com/user-attachments/assets/03df1a87-d3c1-4ba7-8aaa-f8a47cd91613" /> | ### Checklist - [x] I have performed a self-review of my code - [x] My changes generate no new warnings ### Additional notes <!-- Include any additional information, assumptions, or context that reviewers might need to understand this PR. --> --------- Co-authored-by: Mateusz Kopcinski <120639731+mkopcins@users.noreply.github.com> Co-authored-by: Mateusz Sluszniak <56299341+msluszniak@users.noreply.github.com> Co-authored-by: Jakub Gonera <38468585+JakubGonera@users.noreply.github.com> Co-authored-by: Norbert Klockiewicz <Nklockiewicz12@gmail.com> Co-authored-by: pweglik <36445788+pweglik@users.noreply.github.com>
mkopcins
added a commit
that referenced
this pull request
Oct 15, 2025
…ed (#334) ## Description <!-- Provide a concise and descriptive summary of the changes implemented in this PR. --> When I tried to use new whisper release I've noticed that it's for some reason falling into infinite `generating` state. I've done investigation and it turned out that simply I was recording single word what was not longer than 1 chunk. In result it was causing some silent error which prevented model from being triggered. This guard resolves the issue for me. ### Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation update (improves or adds clarity to existing documentation) ### Tested on - [x] iOS - [ ] Android ### Testing instructions <!-- Provide step-by-step instructions on how to test your changes. Include setup details if necessary. --> I cannot share the code but just simply provide very short waveform to `transcribe` method of `useSpeechToText` hook ### Screenshots <!-- Add screenshots here, if applicable --> | Before | After | | --- | --- | | <video src="https://github.com/user-attachments/assets/41754d72-31bb-457a-90ec-f6e4447d0fd8" /> | <video src="https://github.com/user-attachments/assets/03df1a87-d3c1-4ba7-8aaa-f8a47cd91613" /> | ### Checklist - [x] I have performed a self-review of my code - [x] My changes generate no new warnings ### Additional notes <!-- Include any additional information, assumptions, or context that reviewers might need to understand this PR. --> --------- Co-authored-by: Mateusz Kopcinski <120639731+mkopcins@users.noreply.github.com> Co-authored-by: Mateusz Sluszniak <56299341+msluszniak@users.noreply.github.com> Co-authored-by: Jakub Gonera <38468585+JakubGonera@users.noreply.github.com> Co-authored-by: Norbert Klockiewicz <Nklockiewicz12@gmail.com> Co-authored-by: pweglik <36445788+pweglik@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When I tried to use new whisper release I've noticed that it's for some reason falling into infinite
generatingstate.I've done investigation and it turned out that simply I was recording single word what was not longer than 1 chunk.
In result it was causing some silent error which prevented model from being triggered.
This guard resolves the issue for me.
Type of change
Tested on
Testing instructions
I cannot share the code but just simply provide very short waveform to
transcribemethod ofuseSpeechToTexthookScreenshots
Screen.Recording.2025-05-25.at.13.45.34.mov
Screen.Recording.2025-05-25.at.13.45.02.mov
Checklist
Additional notes