Skip to content

MPT-19124 update skip reasons for channel message tests#279

Merged
jentyk merged 1 commit intomainfrom
feat/MPT-19124
Apr 7, 2026
Merged

MPT-19124 update skip reasons for channel message tests#279
jentyk merged 1 commit intomainfrom
feat/MPT-19124

Conversation

@jentyk
Copy link
Copy Markdown
Member

@jentyk jentyk commented Apr 7, 2026

Closes MPT-19124

  • Updated skip reasons for channel message tests in async and sync test files
  • Changed skip reason from "MPT-19124 completed" to "MPT-19696 unblocked" for test_list_channel_messages and test_list_channel_messages_not_found tests

@jentyk jentyk requested a review from a team as a code owner April 7, 2026 08:30
@jentyk jentyk requested review from albertsola and robcsegal April 7, 2026 08:30
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 7, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 27cb28a4-d032-42ce-9435-2badc9ec56c3

📥 Commits

Reviewing files that changed from the base of the PR and between 3aecc19 and e36b7b7.

📒 Files selected for processing (2)
  • tests/e2e/helpdesk/channels/messages/test_async_messages.py
  • tests/e2e/helpdesk/channels/messages/test_sync_messages.py

📝 Walkthrough

Walkthrough

Skip conditions were updated in two E2E test files. The pytest skip reason for test_list_channel_messages and test_list_channel_messages_not_found tests was changed from MPT-19124 completed to MPT-19696 unblocked.

Changes

Cohort / File(s) Summary
Test Skip Reason Updates
tests/e2e/helpdesk/channels/messages/test_async_messages.py, tests/e2e/helpdesk/channels/messages/test_sync_messages.py
Updated pytest skip decorator reasons for two channel message tests from MPT-19124 completed to MPT-19696 unblocked.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Jira Issue Key In Title ✅ Passed The PR title contains exactly one Jira issue key (MPT-19124) in the correct MPT-XXXX format.
Test Coverage Required ✅ Passed PR modifies only test files in tests/ folder updating pytest skip annotations without changing code files in mpt_api_client/ directory.
Single Commit Required ✅ Passed The PR contains exactly one commit (e36b7b7: test(e2e): update skip reasons for channel message tests) with clean linear history.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 7, 2026

@jentyk jentyk merged commit b1e8900 into main Apr 7, 2026
4 checks passed
@jentyk jentyk deleted the feat/MPT-19124 branch April 7, 2026 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants