qrcode.toCanvas with wrong

[ngnono]

version ：0.8.1
my nodejs server on exec qr.code.toCanvas(text,opts,cb) is wrong!!!!
this response :Error: You need to specify a canvas element

on canvas.js function getCanvasElement ()
on browser is ok
on server is not work

this code is

function getCanvasElement () {
  try {
    return document.createElement('canvas')
  } catch (e) {
    throw new Error('You need to specify a canvas element')
  }
}

change into

function getCanvasElement () {
  try {
   //check nodejs env
   if(module && module.exports){
      var Canvas = require('canvas');

      return new Canvas();
    }
    // browser env
    return document.createElement('canvas')
  } catch (e) {
    throw new Error('You need to specify a canvas element')
  }
}

[vigreco]

Hi @ngnono,
we've removed node-canvas dependency, to use canvas in node you need to specify a node-canvas instance as first parameter of toCanvas function.

QRCode.toCanvas(new Canvas(), text, opts, function (err) {
})

[soldair]

@vigreco was this a breaking change or a docs issue?

[vigreco]

@soldair, neither of them I think.
toCanvas is part of new APIs and wasn't available before, so it cannot break code which use old versions.

However, I'll look into it to be sure.

[soldair]

great =) just curious

[ngnono]

okay. :)