Skip to content

Label Designer Sorting: support Public Lists #4754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
darekbienkowski merged 2 commits into from
Dec 11, 2023
Merged

Label Designer Sorting: support Public Lists #4754

darekbienkowski merged 2 commits into from
Dec 11, 2023

Conversation

@dwaring87
Copy link
Member

@dwaring87 dwaring87 commented Dec 5, 2023

Description

Two small fixes to support Public Lists in the label designer when sorting labels by trial layout:

  • recognize the data type of 'Public Lists' in addition to 'Lists'
  • in CXGN::List, allow the exists_list function to return information for public lists

Checklist

  • Refactoring only
  • Documentation only
  • Fixture update only
  • Bug fix
    • The relevant issue has been closed.
    • Further work is required.
  • New feature
    • Relevant tests have been created and run.
    • Data was added to the fixture
      • Data was added via a patch in /t/data/fixture/patches/.
    • User-Facing Change
      • The user manual in /docs has been updated.
    • Any new Perl has been documented using perldoc.
    • Any new JavaScript has been documented using JSDoc.
    • Any new legacy JavaScript has been moved from /js to /js/source/legacy.

bellerbrock
bellerbrock approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@bellerbrock bellerbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fixes, looks good

@darekbienkowski darekbienkowski self-requested a review December 11, 2023 14:59
darekbienkowski
darekbienkowski approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@darekbienkowski darekbienkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

;-)

@darekbienkowski darekbienkowski merged commit 655a346 into master Dec 11, 2023
@darekbienkowski darekbienkowski deleted the topic/label_designer_sorting branch December 11, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darekbienkowski darekbienkowski darekbienkowski approved these changes

@bellerbrock bellerbrock bellerbrock approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dwaring87 @darekbienkowski @bellerbrock