solid: announceRoutes takes either router - #5
Merged
Conversation
A Solid app on TanStack Router had to drop to announcePages + tanstackRouterPages by hand; both helpers live in the same module, so announceRoutes now tells the two instances apart by shape (a TanStack instance carries routesByPath) and the rest of @solidjs/prerender was already router-agnostic. Verified the generated entry runs start.setup inside provideRequestEvent, so the call works where the TanStack router is built. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Solid app on TanStack Router had to drop to announcePages +
tanstackRouterPages by hand; both helpers live in the same module, so
announceRoutes now tells the two instances apart by shape (a TanStack
instance carries routesByPath) and the rest of @solidjs/prerender was
already router-agnostic. Verified the generated entry runs start.setup
inside provideRequestEvent, so the call works where the TanStack router
is built.
Co-authored-by: Cursor cursoragent@cursor.com