Core owns the announce wire; router enumerators move to @solidjs/prerender - #6
Merged
Conversation
…render The crawler should not know any router exists. prerender-crawler/routers becomes prerender-crawler/announce: HINT_HEADER, announcePages, and the documented contract for what a path list holds — nothing else. The router-specific enumerators (solidRouterPages, tanstackRouterPages), their real-instance tests, and the @tanstack/router-core / @solidjs/router dev deps move to @solidjs/prerender, where both routers are the ones Solid apps use. Core is back to depending on nothing. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #4/#5. The generic package should not know any router exists — once it has two, every community asks why theirs isn't in, and core accretes routers whose releases it must track.
prerender-crawler/routers→prerender-crawler/announce:HINT_HEADER,announcePages(request, headers, paths), and the documented contract for what to announce (static, leaf-or-index, no params). Nothing else. README shows a hand-written enumerator so a non-Solid user sees the 5-line pattern.solidRouterPages/tanstackRouterPages, their real-instance tests, and the@tanstack/router-core/@solidjs/routerdev deps move to@solidjs/prerender(exported from both halves; both routers are the ones Solid apps use).announceRoutes(router)unchanged.60 core + 29 solid tests; example build unchanged;
--no-linksCLI run still seeds/postsfrom the announced header.Made with Cursor