docs: clean up the serverFunctions.onError JSDoc - #2266
Merged
birkskyum merged 2 commits intoJul 29, 2026
Conversation
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
commit: |
adipascu
force-pushed
the
docs/server-fn-error-handler-jsdoc
branch
from
July 29, 2026 15:10
b1d3914 to
3b80c45
Compare
adipascu
marked this pull request as draft
July 29, 2026 15:15
2 tasks
adipascu
force-pushed
the
docs/server-fn-error-handler-jsdoc
branch
from
July 29, 2026 15:35
3b80c45 to
b695aa0
Compare
serverFunctions.onError contractserverFunctions.onError JSDoc
adipascu
force-pushed
the
docs/server-fn-error-handler-jsdoc
branch
from
July 29, 2026 15:37
b695aa0 to
cbe53fc
Compare
serverFunctions.onError JSDocserverFunctions.onError JSDoc
adipascu
force-pushed
the
docs/server-fn-error-handler-jsdoc
branch
6 times, most recently
from
July 29, 2026 15:53
6f3d6b2 to
193ade1
Compare
adipascu
marked this pull request as ready for review
July 29, 2026 15:54
birkskyum
approved these changes
Jul 29, 2026
birkskyum
reviewed
Jul 29, 2026
adipascu
force-pushed
the
docs/server-fn-error-handler-jsdoc
branch
2 times, most recently
from
July 29, 2026 16:01
bdd75e3 to
7a73d80
Compare
adipascu
force-pushed
the
docs/server-fn-error-handler-jsdoc
branch
from
July 29, 2026 16:02
7a73d80 to
7ff638e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
What is the current behavior?
Cleanup of my own JSDoc from #2262.
serverFunctions.onErroris documented too thinly to write a handler from, andServerFunctionErrorHandlerhas no doc at all.What is the new behavior?
Behavior unchanged, documentation only. The option now states that:
Responsereaches the handler, so replacing everything breaksredirect()/_serverreach itServerFunctionErrorHandlergets@param,@returns, and an@example, and the inert/** @internal */is dropped.Other information
Comments only, so no tests and no changeset.
Paired with solidjs/solid-docs#1610, which expands the config reference page for this option.