Skip to content

fix(web): include cookie declarations in package - #2985

Merged
ryansolid merged 1 commit into
solidjs:nextfrom
better-salmon:fix/web-cookie-declarations
Aug 10, 2026
Merged

fix(web): include cookie declarations in package#2985
ryansolid merged 1 commit into
solidjs:nextfrom
better-salmon:fix/web-cookie-declarations

Conversation

@better-salmon

Copy link
Copy Markdown

Summary

@solidjs/web exports the cookie API, but its package does not include the related declaration files.

Copy cookies.d.ts during the type build. The CommonJS type step then creates cookies.d.cts.

The package now includes declarations for:

  • parseCookieHeader
  • serializeCookie
  • CookieOptions

How did you test this change?

Ran:

  • pnpm types
  • pnpm --filter @solidjs/web test-types

Both commands passed. Confirmed that the build creates:

  • types/cookies.d.ts
  • types-cjs/cookies.d.cts

Additional comment

The type build uses a manual list of declaration files copied from @dom-expressions/runtime. This list did not include the new cookie declaration file.

Would it be better to copy the full declaration dependency set or add a check for unresolved relative imports? This PR uses the smallest fix, but a general solution could prevent the same issue for future declarations.

@changeset-bot

changeset-bot Bot commented Aug 10, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 63887c2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@solidjs/web Patch
@solidjs/element Patch
@solidjs/h Patch
@solidjs/html Patch
test-integration Patch
chat-example Patch
solid-js Patch
babel-preset-solid Patch
@solidjs/universal Patch
@solidjs/signals Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ryansolid
ryansolid merged commit 3740fde into solidjs:next Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants