fix(web): include cookie declarations in package - #2985
Merged
ryansolid merged 1 commit intoAug 10, 2026
Conversation
🦋 Changeset detectedLatest commit: 63887c2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@solidjs/webexports the cookie API, but its package does not include the related declaration files.Copy
cookies.d.tsduring the type build. The CommonJS type step then createscookies.d.cts.The package now includes declarations for:
parseCookieHeaderserializeCookieCookieOptionsHow did you test this change?
Ran:
pnpm typespnpm --filter @solidjs/web test-typesBoth commands passed. Confirmed that the build creates:
types/cookies.d.tstypes-cjs/cookies.d.ctsAdditional comment
The type build uses a manual list of declaration files copied from
@dom-expressions/runtime. This list did not include the new cookie declaration file.Would it be better to copy the full declaration dependency set or add a check for unresolved relative imports? This PR uses the smallest fix, but a general solution could prevent the same issue for future declarations.