fix(signals): propagate async setter errors - #3262
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: ec587ae The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ryansolid
force-pushed
the
fix/async-setter-error-propagation
branch
from
September 4, 2026 10:35
f631c04 to
ec587ae
Compare
ryansolid
added a commit
that referenced
this pull request
Sep 4, 2026
…atch #3264/#3265/#3266 (+ dev-only #3263) land ~35 B on always-retained store paths, and #3262's handleAsync try/catch adds ~5 B to the core scenarios. A golf pass was attempted and measured strictly worse in every direction (helper extraction +29 B, full inline +70 B, has-trap arm merge -1/+7 B) — the graph is at its brotli optimum post-#3270. Ratchet per convention with audit notes: createStore 14.16 -> 14.20 KB, isPending/latest 10.04 -> 10.05, store-family app 26.25 -> 26.27. No package source changes, no changeset. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Errors thrown by a custom setter while applying an asynchronous computed result currently escape from the promise fulfillment callback. For store projections this can happen when reconciliation invokes a user-provided
keyselector: the application gets an unhandled rejection and the projection does not enter its error state.This routes those errors through the existing async
handleErrorpath, matching rejected computations and the existing handling for errors from async comparators.The regression test uses an ordinary seeded projection whose key selector throws during asynchronous reconciliation, so this fix is independent of the seedless-store proposal.
Testing
pnpm exec vitest run tests/store/createProjection.async.test.ts --reporter=dot(32 tests)pnpm typesinpackages/signals