Skip to content

Adding a check to error out if the ncomp is inconsistent with the num…#279

Merged
bsrunnels merged 3 commits into
developmentfrom
fix-mechanics-ncomp-inconsistency
Apr 16, 2026
Merged

Adding a check to error out if the ncomp is inconsistent with the num…#279
bsrunnels merged 3 commits into
developmentfrom
fix-mechanics-ncomp-inconsistency

Conversation

@bsrunnels

Copy link
Copy Markdown
Member

Currently the mechanics integrator silently ignores initial conditions if nmodels is set to 1, even if multiple models are specified. This puts in an assertion to complain if a different number of models is specified.

@bsrunnels
bsrunnels requested a review from j-stocker April 15, 2026 18:32

@j-stocker j-stocker left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave the expected error when tested

@bsrunnels
bsrunnels merged commit ad7c87d into development Apr 16, 2026
34 checks passed
@bsrunnels
bsrunnels deleted the fix-mechanics-ncomp-inconsistency branch April 16, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants