output: improve Windows console handling#274
Merged
Conversation
The new output code is pretty nifty in Windows Terminal, but users still using the legacy console with cmd.exe or PowerShell are going to get pretty ugly output, since the escape codes aren't handled by default. This adds support for enabling virtual terminal processing, which makes things pretty. (Well, prettier, anyway. Note also #273.)
mrnugget
approved these changes
Aug 21, 2020
Contributor
mrnugget
left a comment
mrnugget
left a comment
There was a problem hiding this comment.
Wow! Going above and beyond here — better Windows console support 😄
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
The new output code is pretty nifty in Windows Terminal, but users still using the legacy console with cmd.exe or PowerShell are going to get pretty ugly output, since the escape codes aren't handled by default. This adds support for enabling virtual terminal processing, which makes things pretty. (Well, prettier, anyway. Note also #273.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new output code is pretty nifty in Windows Terminal, but users still using the legacy console with cmd.exe or PowerShell are going to get pretty ugly output, since the escape codes aren't handled by default. This adds support for enabling virtual terminal processing, which makes things pretty. (Well, prettier, anyway. Note also #273.)