fixes to operator restore flow#296
Merged
Merged
Conversation
RouteRestore short-circuited in in-memory mode by returning nil without writing a response, so the Pilot received an empty 200 and reported the misleading "Failed to communicate with SPIKE Nexus." RouteRecover had no memory-mode check at all and failed later with an equally misleading "not enough shards" internal error. Both routes now reject the request up front with a 400 and a message stating that recovery does not apply to the in-memory backend, which keeps no persistent state to recover or restore. The memory-mode test for restore is updated to the new contract, and recover gains the symmetric test. Spec: TBD Signed-off-by: Volkan Özçelik <volkan.ozcelik@broadcom.com>
`spike operator restore` read the recovery shard exclusively through term.ReadPassword, which fails on a non-TTY stdin. That made the restore flow impossible to script, blocking the planned bare-metal recovery drill (TASKS.md, Phase 3). Extract the prompt into readShardInput: interactive callers keep the hidden-input behavior, while piped or redirected stdin is read to EOF and trimmed. The non-interactive path is covered by a unit test; the doc comment notes that scripted restore leaves a shard copy with the calling process and is meant for development and drills. Spec: TBD Signed-off-by: Volkan Özçelik <volkan.ozcelik@broadcom.com>
Close the cipher stream-mode task (both cipher modes verified passing via the make start checks on 2026-07-15) and the CI integration-test task (CI has been green for several weeks). File the scripted live recovery/restore drill under Phase 3 with the rationale from the 2026-07-16 code review of the flow, and annotate the Phase 1 recovery/restore task to point at it. Spec: TBD Signed-off-by: Volkan Özçelik <volkan.ozcelik@broadcom.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.