Rails 2.3 compatibility #167
Conversation
Rails 2.3 doesn't have Engine support, so disable that and let people add the helpers themselves via an initializer. Based on @RyanNaughton's comments here: splitrb#95
|
@andrew are we supporting Rails 2? |
|
It is extremely easy to make it work with 2.3. We have apps ranging from rails 2.3 to rails 4 at Taxi Magic, and we'd like to be able to do experimentation across all of them equivalently. We have been using the same modifications that @bhcarpenter mentioned above, and it has been working fine. |
|
Yeah, given how unintrusive these changes are, I think it's a good idea. I pity those who are still on 2, but they definitely exist. |
|
i think that it's the "successfull" user base, that's still on rails 2 with AB tests... |
|
At Scoutmob, we're actually planning to run an A/B test across three projects (2 x Rails 3, 1 x Rails 2.3) using a shared Redis. We want to migrate that Rails 2.3 project, but something else always seems to be more pressing. By now we may just wait for Rails 4... |
|
This looks like a simple enough change, looks fine to merge at the moment. |
|
Merging...thanks for the changes @bhcarpenter! |
|
Might as well update the travis config to test rails 2.3 as well |
6 participants
Implemented the suggestions from @RyanNaughton in (unrelated) #95.