Stores and parses Experiment's start_time as a UNIX integer. #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Though UNIX integer representations are used, they are stored as strings and are backwards compatable with the Time stamp representations.
Member
|
Looks great, thanks! |
andrew
added a commit
that referenced
this pull request
Jun 25, 2013
Stores and parses Experiment's start_time as a UNIX integer.
Author
|
Thanks for a great gem! One thing which might be worth thinking about is whether start_time should belong to an experiment version, rather than to the experiment as a whole. This would mean that when an experiment is reset, the start time would effectively be reset for the experiment too. |
Member
|
That's a good point, I'll open it up as a separate issue, cheers! |
This was referenced Jun 29, 2013
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, an Experiment's start_time is stored using Time's to_s method. If this is overridden, parsing fails when the date is later retrieved. Instead, I suggest using UNIX integer timestamps. Though UNIX integer representations are used, they are stored as strings and are backwards compatable with prior representations.