Ensure request is defined before calling methods on it #190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #is_robot? and #is_ignore_ip_address?, request is assumed to be accessible. As a result, the Split::Helper module can only really be included in a Controller context. This commit removes that requirement by conditionally checking that request is defined by attempting to call methods on it.
Member
|
Thanks! |
andrew
added a commit
that referenced
this pull request
Jul 31, 2013
…t-helper Ensure request is defined before calling methods on it
Member
|
I've just released this as part of v0.6.4, thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #is_robot? and #is_ignore_ip_address?, request is assumed to be accessible.
As a result, the Split::Helper module can only really be included in a
Controller context.
This commit removes that requirement by conditionally checking that request is
defined by attempting to call methods on it.