Made Rails ENV display conditional on Rails environment existing using controller; otherwise fallback on Rack version #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Looks better, you'll need to rebase against the latest master before i can merge it |
Member
|
Merged and and released in v0.6.4: https://github.com/andrew/split/releases/tag/v0.6.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For your consideration;
Checks existence of Rails; otherwise assigns current Rack version to instance variable for display in view.
Update to Feature Addition re Issue #186, and #187
No prob if it's a no-go; let me know if there's anything further you can do with it though. Showing current Rails environment in the dashboard could definitely be helpful across distributed setups with production, staging, sandbox, development, and so on; so I welcome any suggestions if you think it can work.