Fix whiplash algorithm when using goals #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…goal completions into account
Member
|
Thanks! |
andrew
added a commit
that referenced
this pull request
Aug 2, 2013
Fix whiplash algorithm when using goals
Member
|
I've just released this as part of v0.6.4, thanks again! |
|
Could we update the README with the differences in using the Whiplash vs Weighted Sample algorithm? There's a note about configuring experiments with Whiplash, but it doesn't explain exactly how it differs from the standard algorithm. |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use all_completed_count instead of completed_count to take goal completions into account. Sorry about all of the seemingly extraneous changes but my editor config removes extra whitespace and adds a linebreak at the end.